Use the patched libxcb library from bug 1334641 on buildbot-based Ubuntu 12.04 testers as well

RESOLVED FIXED

Status

Release Engineering
Buildduty
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: RyanVM, Assigned: aobreja)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 months ago
+++ This bug was initially created as a clone of Bug #1334641 +++

(In reply to Ryan VanderMeulen [:RyanVM] from comment #31)
> mozilla-beta (and soon to be esr52) still runs a number of buildbot-based
> Linux64 tests, and we do in fact see these failures occasionally there as
> well. How easily would we be able to get the updated libxcb library included
> in those AMIs as well?

(In reply to Rail Aliiev [:rail] ⌚️ET from comment #32)
> I think it shouldn't be too hard, just need to publish the fixed binaries to
> the internal apt repos, and update the puppet manifests.
(Assignee)

Updated

9 months ago
Assignee: nobody → aobreja
(Assignee)

Comment 1

9 months ago
Created attachment 8840862 [details] [diff] [review]
bug1341387_puppet.patch

Took patched libxcb library (1.8.1-2ubuntu2.1mozilla2) from bug 1334641 and added to releng-puppet2 along with the actual libxcb (1.8.1-2ubuntu2.1mozilla1) in /data/repos/apt/releng/pool/main/libx.
Also tested on a tst-linux64-ec2 machine this patch which was suppose to update the version of libxcb but I keep getting this error:

"Version '1.8.1-2ubuntu2.1mozilla2' for 'libxcb1' was not found".
Rail I see you worked with this package in Bug 975216 and maybe you have more experience.Can you tell me if there is something that I missed here?
Attachment #8840862 - Flags: feedback?(rail)
Comment on attachment 8840862 [details] [diff] [review]
bug1341387_puppet.patch

Uploading a file is not enough unfortunately. You need to rebuild indexes after that.

IIRC apt indexes don't support more than 1 version of a package in a single repo, so we usually create a repo per new package - it's much safer this way.

https://wiki.mozilla.org/ReleaseEngineering/PuppetAgain/Packages#Ubuntu:_Adding_New_Packages talks about how to add a new repo and https://hg.mozilla.org/build/puppet/rev/7d907471288a is how we usually handle those in puppet.

I hope this helps.
Attachment #8840862 - Flags: feedback?(rail) → feedback-
(Assignee)

Comment 3

9 months ago
Created attachment 8841907 [details] [diff] [review]
bug1341387_puppet.patch

Patch for puppet after adding the package suite in /data/repos/apt/custom/libxcb and tests went successfully on a tst-linux64-ec2 machine:

ii  libxcb1           1.8.1-2ubuntu2.1mozilla2  X C Binding
ii  libxcb1:i386      1.8.1-2ubuntu2.1mozilla2  X C Binding
ii  libxcb1-dev:i386  1.8.1-2ubuntu2.1mozilla2  X C Binding, development files
Attachment #8840862 - Attachment is obsolete: true
Attachment #8841907 - Flags: review?(rail)
Comment on attachment 8841907 [details] [diff] [review]
bug1341387_puppet.patch

Thank you!
Attachment #8841907 - Flags: review?(rail) → review+
(Assignee)

Updated

9 months ago
Attachment #8841907 - Flags: checked-in+
(Assignee)

Updated

9 months ago
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.