1341561 - List of installled updates in about:support says "security updates" for Nightly and they are not security fixes

Status: RESOLVED DUPLICATE of bug 406738

(Toolkit :: General, defect)

Description

[Pascal Chevrel:pascalc]

Attachment: sctreenshot of the bug

STR:
1/ Use a nightly build
2/ Go to about:support
3/ Click on "Show update history" button

ER:
Nightly updates are labelled as regular updates

AR:
Nightly updates are labelled as "security updates" which they are not (see screenshot)

Comment 1

[Pascal Chevrel:pascalc]

Attachment: Bug 1341561: List of installled updates in about:support says "security updates" for Nightly and they are not security fixes

Review commit: https://reviewboard.mozilla.org/r/114500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114500/

Comment 2

[Pascal Chevrel:pascalc]

Comment on attachment 8839933 [details]
Bug 1341561: List of installled updates in about:support says "security updates" for Nightly and they are not security fixes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/114500/diff/1-2/

Comment 3

[Pascal Chevrel:pascalc]

Flod, this patch would introduce a new string, "Regular Update", which would be displayed for Nightly instead of "Security Update".

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8839933 [details]
Bug 1341561: List of installled updates in about:support says "security updates" for Nightly and they are not security fixes

https://reviewboard.mozilla.org/r/114500/#review115976

::: browser/components/preferences/in-content/tests/browser_advanced_update.js:140
(Diff revision 2)
>    is(updates.length, mockUpdateManager.updateCount, "The update count is incorrect.");
>  
>    // Test the updates are displayed correctly
>    let update = null;
>    let updateData = null;
> +  let updateType = AppConstants.NIGHTLY_BUILD ? "Regular Update" : "Security Update";

I think we should not limit the change to nightly on only.
For example, aurora & beta are not security updates either.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Pascal Chevrel:pascalc from comment #3)
> Flod, this patch would introduce a new string, "Regular Update", which would
> be displayed for Nightly instead of "Security Update".

Thanks, don't see any issue with this.

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 8839933 [details]
Bug 1341561: List of installled updates in about:support says "security updates" for Nightly and they are not security fixes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/114500/diff/2-3/