406738 - Non-Security updates should be listed as Non-Security update in Update History.

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

Fx2.0.0.11 and Fx 2.0.0.9 were released as Stability Update, Not Security Update.
But, In Update History in Tools -> Option -> Advanced -> Update -> Show Update History,
They are listed as "Security Update".


Reproducible: Always

Steps to Reproduce:
1.Update Fx to 2.0.0.9 or 2.0.0.11
2.Show update history
3.
Actual Results:  
2.0.0.9 / 2.0.0.11 is displayed as "Security Update"

Expected Results:  
According to Release Note, they are "Stability Update", Not "Security Update".


Target of this bug is limited to OFFICIAL STABLE RELEASE.
At trunk, kind of update is not important information.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I don't think our code currently supports this.

Comment 2

[Masahiro YAMADA]

One of simple idea is , using more abstractly name like
 "Update for Security or Stability"

# Microsoft uses "Cumulative Security Update" for IE distributed by Windows Update.

Comment 3

[Robert Strong (they/them - no direct email)]

limi and faaborg, need a ux decision on this. I think it would be best to just remove this text especially in light of the rapid release process.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

sure

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 406738 - No longer show the kind of updates in 'Show Update History' as they are all marked as "security updates"

Review commit: https://reviewboard.mozilla.org/r/191072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191072/

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Rob, I only removed the text.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8920071 [details]
Bug 406738 - No longer show the kind of updates in 'Show Update History' as they are all marked as "security updates"

https://reviewboard.mozilla.org/r/191072/#review209804

Please also remove https://searchfox.org/mozilla-central/rev/be78e6ea9b10b1f5b2b3b013f01d86e1062abb2b/toolkit/mozapps/update/content/history.js#41 and https://searchfox.org/mozilla-central/rev/be78e6ea9b10b1f5b2b3b013f01d86e1062abb2b/toolkit/locales/en-US/chrome/mozapps/update/updates.properties#23-24


Note: the major vs minor update distinction is still exposed in the update UI with these strings https://searchfox.org/mozilla-central/rev/be78e6ea9b10b1f5b2b3b013f01d86e1062abb2b/toolkit/locales/en-US/chrome/mozapps/update/updates.properties#20-21,38-41,65-66 shown by https://searchfox.org/mozilla-central/rev/be78e6ea9b10b1f5b2b3b013f01d86e1062abb2b/toolkit/mozapps/update/content/updates.js#649
Do we also want to remove this? If so I think it's fine to do it in a follow-up bug.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8920071 [details]
Bug 406738 - No longer show the kind of updates in 'Show Update History' as they are all marked as "security updates"

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191072/diff/1-2/

Comment 10

[Florian Quèze [:florian]]

Comment on attachment 8920071 [details]
Bug 406738 - No longer show the kind of updates in 'Show Update History' as they are all marked as "security updates"

https://reviewboard.mozilla.org/r/191072/#review210202

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/313e0c5a2081
No longer show the kind of updates in 'Show Update History' as they are all marked as "security updates" r=florian

Comment 12

[Natalia Csoregi [:nataliaCs]]

Backed out for failing browser-chrome's browser/components/preferences/in-content/tests/browser_advanced_update.js

Backout - https://hg.mozilla.org/integration/autoland/rev/3855c1a28dc30df652f80c79dcbf0ff8cabd1209

Push with failures - https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=313e0c5a20813e0c21be9c0d3a69e3910eca84cd

Failure log : https://treeherder.mozilla.org/logviewer.html#?job_id=149145476&repo=autoland&lineNumber=2435

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8920071 [details]
Bug 406738 - No longer show the kind of updates in 'Show Update History' as they are all marked as "security updates"

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191072/diff/2-3/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c426018cfe42
No longer show the kind of updates in 'Show Update History' as they are all marked as "security updates" r=florian

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c426018cfe42