Form autofill popup won't apply to an auto-focused input until it's refocused

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Form Manager
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: lchang, Assigned: lchang)

Tracking

(Blocks: 1 bug)

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [form autofill:M1])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
The form autofill popup won't appear on an input which is auto-focused by the website.
(Assignee)

Comment 1

6 months ago
It can be tested in https://luke-chang.github.io/autofill-demo/basic.html
Comment hidden (mozreview-request)
(Assignee)

Comment 3

6 months ago
The root cause of this bug is the same as bug 1311301 so I applied its approach in our "MarkAsAutofillField". It works except that the page is loaded in a new tab first time. That's because "AutofillProfileAutoCompleteSearch" hasn't finished registering when we call "MaybeStartControllingInput" in "MarkAsAutofillField". Therefore, "form-history" will be used alternatively.

In this patch I changed the loader of "FormAutofillContent.jsm" back to "Cu.import" to initialize it in the beginning. I also removed the "_" prefix of "_identifyAutofillFields" to explicitly describe it as a public method.


Hi Matt, Could you take a look? Thanks.
Comment on attachment 8840387 [details]
Bug 1341582 - Apply form autofill to an already-focused input,

https://reviewboard.mozilla.org/r/114906/#review116650

Thanks
Attachment #8840387 - Flags: review?(MattN+bmo) → review+
(Assignee)

Comment 5

6 months ago
Matt, Thanks for the review.
Keywords: checkin-needed

Comment 6

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0fac3630e21b
Apply form autofill to an already-focused input, r=MattN
Keywords: checkin-needed

Comment 7

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0fac3630e21b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
(Assignee)

Updated

5 months ago
Duplicate of this bug: 1325537
You need to log in before you can comment on or make changes to this bug.