1341763 - stylo: need -moz-image-rect support

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Again, probably this is mostly servo-side....

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1341763 - stylo: Rename and move PercentageOrNumber to values

Review commit: https://reviewboard.mozilla.org/r/123590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123590/

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1341763 - stylo: Add support for -moz-image-rect value

Review commit: https://reviewboard.mozilla.org/r/123592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123592/

Comment 3

[Manish Goregaokar [:manishearth]]

Comment on attachment 8851221 [details]
Bug 1341763 - stylo: Rename and move PercentageOrNumber to values

https://reviewboard.mozilla.org/r/123590/#review126082

::: servo/components/style/gecko/values.rs:69
(Diff revision 1)
>  
> +impl GeckoStyleCoordConvertible for NumberOrPercentage {
> +    fn to_gecko_style_coord<T: CoordDataMut>(&self, coord: &mut T) {
> +        match *self {
> +            NumberOrPercentage::Number(ref n) => n.to_gecko_style_coord(coord),
> +            NumberOrPercentage::Percentage(p) => coord.set_value(CoordDataValue::Percent(p)),

does p.to_gecko_style_coord not work?

(If it doesn't,  we should probably add a GSCC impl for Percentage)

Edit: Oh, I see, you are using CSSFloat and not Percent -- that should be changed.

::: servo/components/style/values/computed/mod.rs:271
(Diff revision 1)
>  
> +#[derive(Debug, Clone, PartialEq)]
> +#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
> +#[allow(missing_docs)]
> +pub enum NumberOrPercentage {
> +    Percentage(CSSFloat),

Use the Percentage type here, it has ToCss impls and stuff that are useful.

::: servo/components/style/values/specified/mod.rs:567
(Diff revision 1)
> +        if let Ok(per) = input.try(|input| Percentage::parse(context, input)) {
> +            return Ok(NumberOrPercentage::Percentage(per));
> +        }
> +
> +        let num = try!(Number::parse_non_negative(input));
> +        Ok(NumberOrPercentage::Number(num))

nonnegativeness of the number should be documented somewhere, preferably on numberorpercentage itself

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8851222 [details]
Bug 1341763 - stylo: Add support for -moz-image-rect value

https://reviewboard.mozilla.org/r/123592/#review126084

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8851221 [details]
Bug 1341763 - stylo: Rename and move PercentageOrNumber to values

https://reviewboard.mozilla.org/r/123590/#review126082

> Use the Percentage type here, it has ToCss impls and stuff that are useful.

I thought this too when I wrote it but there is no computed Percentage type in servo currently. All other types like LengthOrPercentage uses CSSFloat for computed percentage. I should write that.

> nonnegativeness of the number should be documented somewhere, preferably on numberorpercentage itself

Ok, will do.

Comment 6

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8851221 [details]
Bug 1341763 - stylo: Rename and move PercentageOrNumber to values

https://reviewboard.mozilla.org/r/123590/#review126082

> I thought this too when I wrote it but there is no computed Percentage type in servo currently. All other types like LengthOrPercentage uses CSSFloat for computed percentage. I should write that.

Oh, or probably I can use specified Percentage and add `ComputedValueAsSpecified` to Percentage for this since there are no differences with specified and computed.

Comment 7

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1341763 - stylo: Update test expectations

Review commit: https://reviewboard.mozilla.org/r/123612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123612/

Comment 8

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8851221 [details]
Bug 1341763 - stylo: Rename and move PercentageOrNumber to values

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123590/diff/1-2/

Comment 9

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8851222 [details]
Bug 1341763 - stylo: Add support for -moz-image-rect value

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123592/diff/1-2/

Comment 10

[Manish Goregaokar [:manishearth]]

Comment on attachment 8851260 [details]
Bug 1341763 - stylo: Update test expectations

https://reviewboard.mozilla.org/r/123612/#review126102

Go forth and split the commits :)

Comment 11

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Btw, the gecko and stylo test reference listings were different at some places. For example it was `== dom-api-computed-style.html dom-api-ref.html` in the gecko side but `fails == dom-api-computed-style.html dom-api-computed-style.html` in stylo side. I changed to match with gecko. Is it true?

Comment 12

[Manish Goregaokar [:manishearth]]

No, keep it as is. The gecko tests test gecko rendering of foo.html with gecko rendering of foo-ref.html. The stylo tests test stylo rendering of foo.html against gecko rendering of foo.html -- for stylo correctness we want it to look like gecko, not necessarily pass all reftests.

Comment 13

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8851222 [details]
Bug 1341763 - stylo: Add support for -moz-image-rect value

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123592/diff/2-3/

Comment 14

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 8851260 [details]
Bug 1341763 - stylo: Update test expectations

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123612/diff/1-2/

Comment 15

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Ok, reversed the reftests. Related Servo part: https://github.com/servo/servo/pull/16133

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b315010da573
stylo: Add support for -moz-image-rect value r=manishearth
https://hg.mozilla.org/integration/autoland/rev/aadf315df1f8
stylo: Update test expectations r=manishearth

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b315010da573
https://hg.mozilla.org/mozilla-central/rev/aadf315df1f8