1350714 - Intermittent image-rect/background-draw-nothing-malformed-images.html | assertion count 8 is more than expected 0 to 6 assertions

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=86507418&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/MAyMpvvbQ2KFXlHmlZNVtQ/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/MAyMpvvbQ2KFXlHmlZNVtQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Fallout from bug 1341763.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

The same bug was also causing an assertion failure I fixed at https://github.com/servo/servo/pull/16142, btw. Nazim, could you look at the assertions?

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

This feels like a permafail rather than an intermittent one, actually...

Comment 4

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Yeah, permafail since https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=aadf315df1f8055159cd1a6fe816a1c44a21ca84

It looks like all 8 assertions are

[task 2017-03-26T14:29:27.392710Z] 14:29:27     INFO - [Child 1287] ###!!! ASSERTION: ComputeActualCropRect() should not fail here: 'success', file /home/worker/workspace/build/src/layout/painting/nsImageRenderer.cpp, line 133
[task 2017-03-26T14:29:48.428297Z] 14:29:48     INFO - #01: mozilla::nsImageRenderer::PrepareImage [layout/painting/nsImageRenderer.cpp:108]
[task 2017-03-26T14:29:48.429461Z] 14:29:48     INFO - #02: nsCSSRendering::PrepareImageLayer [layout/painting/nsCSSRendering.cpp:3962]
[task 2017-03-26T14:29:48.429640Z] 14:29:48     INFO - #03: nsDisplayBackgroundImage::GetInitData [layout/painting/nsDisplayList.cpp:2861]
[task 2017-03-26T14:29:48.432049Z] 14:29:48     INFO - #04: nsDisplayBackgroundImage::AppendBackgroundItemsToTop [layout/painting/nsDisplayList.cpp:3119]
[task 2017-03-26T14:29:48.434227Z] 14:29:48     INFO - #05: nsFrame::DisplayBackgroundUnconditional [layout/generic/nsFrame.cpp:2065]
[task 2017-03-26T14:29:48.436428Z] 14:29:48     INFO - #06: nsFrame::DisplayBorderBackgroundOutline [layout/generic/nsFrame.cpp:2091]
[task 2017-03-26T14:29:48.438744Z] 14:29:48     INFO - #07: nsBlockFrame::BuildDisplayList [layout/generic/nsBlockFrame.cpp:6627]
[task 2017-03-26T14:29:48.440964Z] 14:29:48     INFO - #08: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127]
[task 2017-03-26T14:29:48.443167Z] 14:29:48     INFO - #09: DisplayLine [layout/generic/nsBlockFrame.cpp:6588]
[task 2017-03-26T14:29:48.445412Z] 14:29:48     INFO - #10: nsBlockFrame::BuildDisplayList [layout/generic/nsBlockFrame.cpp:6680]
[task 2017-03-26T14:29:48.447701Z] 14:29:48     INFO - #11: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127]
[task 2017-03-26T14:29:48.449936Z] 14:29:48     INFO - #12: DisplayLine [layout/generic/nsBlockFrame.cpp:6588]
[task 2017-03-26T14:29:48.452118Z] 14:29:48     INFO - #13: nsBlockFrame::BuildDisplayList [layout/generic/nsBlockFrame.cpp:6680]
[task 2017-03-26T14:29:48.454379Z] 14:29:48     INFO - #14: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127]
[task 2017-03-26T14:29:48.456580Z] 14:29:48     INFO - #15: DisplayLine [layout/generic/nsBlockFrame.cpp:6588]
[task 2017-03-26T14:29:48.458763Z] 14:29:48     INFO - #16: nsBlockFrame::BuildDisplayList [layout/generic/nsBlockFrame.cpp:6680]
[task 2017-03-26T14:29:48.460970Z] 14:29:48     INFO - #17: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127]
[task 2017-03-26T14:29:48.463156Z] 14:29:48     INFO - #18: nsCanvasFrame::BuildDisplayList [layout/generic/nsCanvasFrame.cpp:589]
[task 2017-03-26T14:29:48.465464Z] 14:29:48     INFO - #19: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127]
[task 2017-03-26T14:29:48.467681Z] 14:29:48     INFO - #20: mozilla::ScrollFrameHelper::BuildDisplayList [layout/generic/nsGfxScrollFrame.cpp:3481]
[task 2017-03-26T14:29:48.469936Z] 14:29:48     INFO - #21: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127]
[task 2017-03-26T14:29:48.472288Z] 14:29:48     INFO - #22: mozilla::ViewportFrame::BuildDisplayList [layout/generic/ViewportFrame.cpp:69]
[task 2017-03-26T14:29:48.474476Z] 14:29:48     INFO - #23: nsIFrame::BuildDisplayListForStackingContext [layout/generic/nsFrame.cpp:2554]
[task 2017-03-26T14:29:48.476709Z] 14:29:48     INFO - #24: nsLayoutUtils::PaintFrame [layout/painting/nsDisplayList.h:946]
[task 2017-03-26T14:29:48.478879Z] 14:29:48     INFO - #25: mozilla::PresShell::Paint [layout/base/PresShell.cpp:6499]
[task 2017-03-26T14:29:48.481111Z] 14:29:48     INFO - #26: nsDOMWindowUtils::UpdateLayerTree [gfx/src/nsRegion.h:75]
[task 2017-03-26T14:29:48.483296Z] 14:29:48     INFO - #27: NS_InvokeByIndex


Since we already expect up to 6 assertions, perhaps we should just increase the expected assertion range:

https://dxr.mozilla.org/mozilla-central/rev/e03e0c60462c775c7558a1dc9d5cf2076c3cd1f9/layout/reftests/image-rect/reftest-stylo.list#7

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Oh, sure. I'll look at this.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

So, I investigated a bit, and Gecko seems to do the request for this stuff while computing style. We do have similar stuff in place I think, but I believe it's not hooked in.

So we somehow end with an image that errored (because the URL is invalid) in paint code. I need to page back in how all the image request stuff works right now, perhaps heycam may remember better.

But yeah, given it's pre-existing, we may as well bump the expected assertion count for now.

Comment 7

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1350714 - Increase expected assertion range to 8 for background-draw-nothing-malformed-images.html

Review commit: https://reviewboard.mozilla.org/r/123956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123956/

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8851718 [details]
Bug 1350714 - Increase expected assertion range to 8 for background-draw-nothing-malformed-images.html

https://reviewboard.mozilla.org/r/123956/#review126470

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21ef22437c0e
Increase expected assertion range to 8 for background-draw-nothing-malformed-images.html r=emilio

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/21ef22437c0e

Comment 11

[Intermittent Failures Robot]

81 failures in 141 pushes (0.574 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 56
* mozilla-inbound: 22
* mozilla-central: 3

Platform breakdown:
* linux64-stylo: 81

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1350714&startday=2017-03-27&endday=2017-03-27&tree=all

Comment 12

[Intermittent Failures Robot]

88 failures in 845 pushes (0.104 failures/push) were associated with this bug in the last 7 days. 

This is the #16 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 56
* mozilla-inbound: 26
* try: 3
* mozilla-central: 3

Platform breakdown:
* linux64-stylo: 88

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1350714&startday=2017-03-27&endday=2017-04-02&tree=all