Closed
Bug 1350714
Opened 7 years ago
Closed 7 years ago
Intermittent image-rect/background-draw-nothing-malformed-images.html | assertion count 8 is more than expected 0 to 6 assertions
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: canova)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])
Attachments
(1 file)
Filed by: archaeopteryx [at] coole-files.de https://treeherder.mozilla.org/logviewer.html#?job_id=86507418&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/MAyMpvvbQ2KFXlHmlZNVtQ/runs/0/artifacts/public/logs/live_backing.log https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/MAyMpvvbQ2KFXlHmlZNVtQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Comment 2•7 years ago
|
||
The same bug was also causing an assertion failure I fixed at https://github.com/servo/servo/pull/16142, btw. Nazim, could you look at the assertions?
Flags: needinfo?(canaltinova)
Comment 3•7 years ago
|
||
This feels like a permafail rather than an intermittent one, actually...
Comment 4•7 years ago
|
||
Yeah, permafail since https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=aadf315df1f8055159cd1a6fe816a1c44a21ca84 It looks like all 8 assertions are [task 2017-03-26T14:29:27.392710Z] 14:29:27 INFO - [Child 1287] ###!!! ASSERTION: ComputeActualCropRect() should not fail here: 'success', file /home/worker/workspace/build/src/layout/painting/nsImageRenderer.cpp, line 133 [task 2017-03-26T14:29:48.428297Z] 14:29:48 INFO - #01: mozilla::nsImageRenderer::PrepareImage [layout/painting/nsImageRenderer.cpp:108] [task 2017-03-26T14:29:48.429461Z] 14:29:48 INFO - #02: nsCSSRendering::PrepareImageLayer [layout/painting/nsCSSRendering.cpp:3962] [task 2017-03-26T14:29:48.429640Z] 14:29:48 INFO - #03: nsDisplayBackgroundImage::GetInitData [layout/painting/nsDisplayList.cpp:2861] [task 2017-03-26T14:29:48.432049Z] 14:29:48 INFO - #04: nsDisplayBackgroundImage::AppendBackgroundItemsToTop [layout/painting/nsDisplayList.cpp:3119] [task 2017-03-26T14:29:48.434227Z] 14:29:48 INFO - #05: nsFrame::DisplayBackgroundUnconditional [layout/generic/nsFrame.cpp:2065] [task 2017-03-26T14:29:48.436428Z] 14:29:48 INFO - #06: nsFrame::DisplayBorderBackgroundOutline [layout/generic/nsFrame.cpp:2091] [task 2017-03-26T14:29:48.438744Z] 14:29:48 INFO - #07: nsBlockFrame::BuildDisplayList [layout/generic/nsBlockFrame.cpp:6627] [task 2017-03-26T14:29:48.440964Z] 14:29:48 INFO - #08: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127] [task 2017-03-26T14:29:48.443167Z] 14:29:48 INFO - #09: DisplayLine [layout/generic/nsBlockFrame.cpp:6588] [task 2017-03-26T14:29:48.445412Z] 14:29:48 INFO - #10: nsBlockFrame::BuildDisplayList [layout/generic/nsBlockFrame.cpp:6680] [task 2017-03-26T14:29:48.447701Z] 14:29:48 INFO - #11: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127] [task 2017-03-26T14:29:48.449936Z] 14:29:48 INFO - #12: DisplayLine [layout/generic/nsBlockFrame.cpp:6588] [task 2017-03-26T14:29:48.452118Z] 14:29:48 INFO - #13: nsBlockFrame::BuildDisplayList [layout/generic/nsBlockFrame.cpp:6680] [task 2017-03-26T14:29:48.454379Z] 14:29:48 INFO - #14: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127] [task 2017-03-26T14:29:48.456580Z] 14:29:48 INFO - #15: DisplayLine [layout/generic/nsBlockFrame.cpp:6588] [task 2017-03-26T14:29:48.458763Z] 14:29:48 INFO - #16: nsBlockFrame::BuildDisplayList [layout/generic/nsBlockFrame.cpp:6680] [task 2017-03-26T14:29:48.460970Z] 14:29:48 INFO - #17: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127] [task 2017-03-26T14:29:48.463156Z] 14:29:48 INFO - #18: nsCanvasFrame::BuildDisplayList [layout/generic/nsCanvasFrame.cpp:589] [task 2017-03-26T14:29:48.465464Z] 14:29:48 INFO - #19: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127] [task 2017-03-26T14:29:48.467681Z] 14:29:48 INFO - #20: mozilla::ScrollFrameHelper::BuildDisplayList [layout/generic/nsGfxScrollFrame.cpp:3481] [task 2017-03-26T14:29:48.469936Z] 14:29:48 INFO - #21: nsIFrame::BuildDisplayListForChild [layout/generic/nsFrame.cpp:3127] [task 2017-03-26T14:29:48.472288Z] 14:29:48 INFO - #22: mozilla::ViewportFrame::BuildDisplayList [layout/generic/ViewportFrame.cpp:69] [task 2017-03-26T14:29:48.474476Z] 14:29:48 INFO - #23: nsIFrame::BuildDisplayListForStackingContext [layout/generic/nsFrame.cpp:2554] [task 2017-03-26T14:29:48.476709Z] 14:29:48 INFO - #24: nsLayoutUtils::PaintFrame [layout/painting/nsDisplayList.h:946] [task 2017-03-26T14:29:48.478879Z] 14:29:48 INFO - #25: mozilla::PresShell::Paint [layout/base/PresShell.cpp:6499] [task 2017-03-26T14:29:48.481111Z] 14:29:48 INFO - #26: nsDOMWindowUtils::UpdateLayerTree [gfx/src/nsRegion.h:75] [task 2017-03-26T14:29:48.483296Z] 14:29:48 INFO - #27: NS_InvokeByIndex Since we already expect up to 6 assertions, perhaps we should just increase the expected assertion range: https://dxr.mozilla.org/mozilla-central/rev/e03e0c60462c775c7558a1dc9d5cf2076c3cd1f9/layout/reftests/image-rect/reftest-stylo.list#7
Updated•7 years ago
|
Whiteboard: [stockwell needswork]
Comment 6•7 years ago
|
||
So, I investigated a bit, and Gecko seems to do the request for this stuff while computing style. We do have similar stuff in place I think, but I believe it's not hooked in. So we somehow end with an image that errored (because the URL is invalid) in paint code. I need to page back in how all the image request stuff works right now, perhaps heycam may remember better. But yeah, given it's pre-existing, we may as well bump the expected assertion count for now.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → canaltinova
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8851718 [details] Bug 1350714 - Increase expected assertion range to 8 for background-draw-nothing-malformed-images.html https://reviewboard.mozilla.org/r/123956/#review126470
Attachment #8851718 -
Flags: review?(emilio+bugs) → review+
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/21ef22437c0e Increase expected assertion range to 8 for background-draw-nothing-malformed-images.html r=emilio
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/21ef22437c0e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Flags: needinfo?(manishearth)
Updated•7 years ago
|
Whiteboard: [stockwell needswork] → [stockwell fixed]
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•