1341968 - Update webrender to 501e3d79c8a3019762bd8bd2d00eecf7811a84de

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1340270 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 5c1774462ee57b209ab81295ab944a176f2913f5

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4be53bcbe529a11294ea01111176d89841f8913e

Busted, because of ImageDescriptor changes. I'll write a patch for webrender_bindings.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Update for ImageDescriptor

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Update for add_image

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 0ac6dfdfdbf969c71bfe79b675027e3ec0697d80

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf702d9a264211d9baa86744365bb872c81e107f

With patches, looks green.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ c83500198f0822427d7c8eba2099195dcd693f79

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64af15ff6b22841a6eaa30a3a15cf329eb1215f7

Also green. My cron script fell down over the weekend because of a tree closure so I ran it again manually for this one.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

This picks up the fix for bug 1341745 and allows turning on mochitest-webgl.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1341968 - Update webrender to commit 501e3d79c8a3019762bd8bd2d00eecf7811a84de.

Review commit: https://reviewboard.mozilla.org/r/115786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115786/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1341968 - Update webrender_bindings to go with new offset field in ImageDescriptor.

Review commit: https://reviewboard.mozilla.org/r/115788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115788/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1341968 - Update webrender_bindings to go with new tiling argument to add_image.

Review commit: https://reviewboard.mozilla.org/r/115790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115790/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1341968 - Update webrender_bindings to go with the set_root_display_list API change.

Review commit: https://reviewboard.mozilla.org/r/115792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115792/

Comment 11

[Kartikaya Gupta (email:[e-mail])]

I'll squash together the patches for landing.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Latest try push is green as well: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1d69d1eb1f4d39f55b8fd5b0df59944b435c258

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8841627 [details]
Bug 1341968 - Update webrender to commit 501e3d79c8a3019762bd8bd2d00eecf7811a84de.

https://reviewboard.mozilla.org/r/115786/#review117208

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8841630 [details]
Bug 1341968 - Update webrender_bindings to go with the set_root_display_list API change.

https://reviewboard.mozilla.org/r/115792/#review117210

Comment 15

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8841629 [details]
Bug 1341968 - Update webrender_bindings to go with new tiling argument to add_image.

https://reviewboard.mozilla.org/r/115790/#review117212

Comment 16

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8841628 [details]
Bug 1341968 - Update webrender_bindings to go with new offset field in ImageDescriptor.

https://reviewboard.mozilla.org/r/115788/#review117214

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/fb90c86d6503
Update webrender to commit 501e3d79c8a3019762bd8bd2d00eecf7811a84de. r=jrmuizel

Comment 18

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/fb90c86d6503