Closed Bug 1342095 Opened 3 years ago Closed 3 years ago

Disable SharedArrayBuffer and Atomics on FF52

Categories

(Core :: JavaScript Engine, defect, P1)

52 Branch
defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- unaffected
firefox54 --- unaffected

People

(Reporter: lth, Assigned: lth)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

This patch may or may not land but I need a review on it in case it needs to land; decision to be made at the executive level.

Try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=86acacd0d20c7ca016db17bcc814b321f9a77815

The patch is for mozilla-beta (only).  It effectively reverts bug 1312446 (which landed on aurora before we branched last time).
Attachment #8840462 - Flags: review?(shu)
Comment on attachment 8840462 [details] [diff] [review]
disable-sab-and-atomics-on-beta.patch

Review of attachment 8840462 [details] [diff] [review]:
-----------------------------------------------------------------

boo on exploits
Attachment #8840462 - Flags: review?(shu) → review+
Comment on attachment 8840462 [details] [diff] [review]
disable-sab-and-atomics-on-beta.patch

Approval Request Comment
[Feature/Bug causing the regression]: Shared memory and atomics
[User impact if declined]: Feature will be exposed to all users but must not be
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Sort of, see "Risk"
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Months of testing have preceded this, it has been disabled on beta/release before (see comment 0) and this patch just reverts the patch that enabled the feature for beta/release.
[String changes made/needed]: None

The feature was enabled on release/beta to get more exposure, but it is not going to ship in FF52 by decision at the executive level (Martin Best).  This patch is for beta only, aurora and central remain unchanged.
Attachment #8840462 - Flags: approval-mozilla-beta?
Comment on attachment 8840462 [details] [diff] [review]
disable-sab-and-atomics-on-beta.patch

disable a feature for 52 release, beta52+

Should be in rc1 monday.
Attachment #8840462 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Setting qe-verify- based on Lars' assessment on manual testing needs (see Comment 2) and the fact that this fix has automated coverage.
Flags: qe-verify-
SAB has been removed from Fx 52 developer release notes and the compatibility tables in the reference docs have been reverted.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Atomics
Please flag the bug that brings this back with "dev-doc-needed".
You need to log in before you can comment on or make changes to this bug.