1342293 - generatePageErrorStubs should call expectUncaughtException for each exception.

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Tooru Fujisawa [:arai]]

discovered by bug 104442.

https://dxr.mozilla.org/mozilla-central/rev/32dcdde1fc64fc39a9065dc4218265dbc727673f/testing/mochitest/tests/SimpleTest/SimpleTest.js#1383-1389
> /**
>  * Indicates to the test framework that the next uncaught exception during
>  * the test is expected, and should not cause a test failure.
>  */
> SimpleTest.expectUncaughtException = function (aExpecting) {
>     SimpleTest._expectingUncaughtException = aExpecting === void 0 || !!aExpecting;
> };

currently browser_webconsole_check_stubs_page_error.js calls it only once, but it should be done by generatePageErrorStubs for each entry of pageError.

https://dxr.mozilla.org/mozilla-central/rev/32dcdde1fc64fc39a9065dc4218265dbc727673f/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser_webconsole_check_stubs_page_error.js#11-15

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Call expectUncaughtException for each pageError.

Moved expectUncaughtException() to loop inside generatePageErrorStubs

Comment 2

[Tooru Fujisawa [:arai]]

(this patch will conflict with bug 1342215 patch, but the rebase should be trivial, since the actual change is not related)

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8840692 [details] [diff] [review]
Call expectUncaughtException for each pageError.

Review of attachment 8840692 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks !

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c618b06686e986428a0aa186081e32f74d75ace0
Bug 1342293 - Call expectUncaughtException for each pageError. r=nchevobbe

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c618b06686e9