Closed
Bug 1342293
Opened 7 years ago
Closed 7 years ago
generatePageErrorStubs should call expectUncaughtException for each exception.
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
2.80 KB,
patch
|
nchevobbe
:
review+
|
Details | Diff | Splinter Review |
discovered by bug 104442. https://dxr.mozilla.org/mozilla-central/rev/32dcdde1fc64fc39a9065dc4218265dbc727673f/testing/mochitest/tests/SimpleTest/SimpleTest.js#1383-1389 > /** > * Indicates to the test framework that the next uncaught exception during > * the test is expected, and should not cause a test failure. > */ > SimpleTest.expectUncaughtException = function (aExpecting) { > SimpleTest._expectingUncaughtException = aExpecting === void 0 || !!aExpecting; > }; currently browser_webconsole_check_stubs_page_error.js calls it only once, but it should be done by generatePageErrorStubs for each entry of pageError. https://dxr.mozilla.org/mozilla-central/rev/32dcdde1fc64fc39a9065dc4218265dbc727673f/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser_webconsole_check_stubs_page_error.js#11-15
Assignee | ||
Comment 1•7 years ago
|
||
Moved expectUncaughtException() to loop inside generatePageErrorStubs
Attachment #8840692 -
Flags: review?(chevobbe.nicolas)
Assignee | ||
Comment 2•7 years ago
|
||
(this patch will conflict with bug 1342215 patch, but the rebase should be trivial, since the actual change is not related)
Comment 3•7 years ago
|
||
Comment on attachment 8840692 [details] [diff] [review] Call expectUncaughtException for each pageError. Review of attachment 8840692 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks !
Attachment #8840692 -
Flags: review?(chevobbe.nicolas) → review+
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c618b06686e986428a0aa186081e32f74d75ace0 Bug 1342293 - Call expectUncaughtException for each pageError. r=nchevobbe
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c618b06686e9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•