Closed Bug 1342333 Opened 7 years ago Closed 5 years ago
Remove any use of ns
IURLClassifier .classify Local With Tables on the main thread
It appears many uses of nsIURLClassifier.classifyLocalWithTables are on main thread and the function is synchronous. We should remove all of them. Works also include the IPC counter part.
Summary: Remove any use of nsIURLClassifier.classifyLocalWithTables → Remove any use of nsIURLClassifier.classifyLocalWithTables on the main thread
Given that the implementation of nsIURLClassifier.classifyLocalWithTables()  forces it to be called on the main thread, we may in the end just remove this function.  http://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1634
Assignee: hchang → nobody
Status: ASSIGNED → NEW
We don't have any solution for this at this moment. Put it to the backlog.
Priority: P2 → P5
Whiteboard: [qf:meta] → [qf:meta][sb-backlog]
Henry, please add some comments for a detailed explanation.
Backlog is P3.
Priority: P5 → P3
Whiteboard: [qf:meta][sb-backlog] → [qf:meta]
We wanted to remove all uses of the sync API: nsIURLClassifier.classifyLocalWithTables and bug 1345058 used to be the last mile until we figured out we are unable to totally get rid of it without an enormous work. We are taking the sub-optimal solution which will decrease the probability of using this API. In other words, fixing bug 1345058 doesn't mean we can remove the sync API.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Performance Impact: --- → ?
You need to log in before you can comment on or make changes to this bug.