Closed
Bug 1342333
Opened 7 years ago
Closed 5 years ago
Remove any use of nsIURLClassifier.classifyLocalWithTables on the main thread
Categories
(Toolkit :: Safe Browsing, defect, P3)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
DUPLICATE
of bug 1515272
Performance Impact | ? |
People
(Reporter: hchang, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: meta, perf)
It appears many uses of nsIURLClassifier.classifyLocalWithTables are on main thread and the function is synchronous. We should remove all of them. Works also include the IPC counter part.
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → hchang
Reporter | ||
Updated•7 years ago
|
Summary: Remove any use of nsIURLClassifier.classifyLocalWithTables → Remove any use of nsIURLClassifier.classifyLocalWithTables on the main thread
Reporter | ||
Comment 1•7 years ago
|
||
Given that the implementation of nsIURLClassifier.classifyLocalWithTables() [1] forces it to be called on the main thread, we may in the end just remove this function. [1] http://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1634
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Updated•7 years ago
|
Updated•7 years ago
|
Whiteboard: [qf:meta]
Reporter | ||
Updated•6 years ago
|
Assignee: hchang → nobody
Status: ASSIGNED → NEW
Comment 2•6 years ago
|
||
We don't have any solution for this at this moment. Put it to the backlog.
Priority: P2 → P5
Whiteboard: [qf:meta] → [qf:meta][sb-backlog]
Comment 3•6 years ago
|
||
Henry, please add some comments for a detailed explanation.
Flags: needinfo?(hchang)
Comment 4•6 years ago
|
||
Backlog is P3.
Priority: P5 → P3
Whiteboard: [qf:meta][sb-backlog] → [qf:meta]
Reporter | ||
Comment 5•6 years ago
|
||
We wanted to remove all uses of the sync API: nsIURLClassifier.classifyLocalWithTables and bug 1345058 used to be the last mile until we figured out we are unable to totally get rid of it without an enormous work. We are taking the sub-optimal solution which will decrease the probability of using this API. In other words, fixing bug 1345058 doesn't mean we can remove the sync API.
Flags: needinfo?(hchang)
Comment 6•5 years ago
|
||
The synchronous API is removed in Bug 1515272 because of fantastic work was done by baku in Bug 1514202.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•