1342363 - Update cubeb from upstream to 25b593f

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Alex Chronopoulos [:achronop]]

Update cubeb from upstream to 25b593f. Commits log from previous import:

25b593f audiounit: Address issue #240 plus minor cleanups (#241)
3381056 Update AUTHORS
52c6093 audiounit: prevent deadlock by avoiding creating AU when getting channel layout
91c40d3 wasapi: fix two crashes (Bug 1340278, Bug 1340289)
4edf825 Allow to prebuffer more data when in debug.

Comment 1

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef75aa7f18b9

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1342363 - Update cubeb from upstream to 25b593f.

Review commit: https://reviewboard.mozilla.org/r/115308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115308/

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8840879 [details]
Bug 1342363 - Update cubeb from upstream to 25b593f.

https://reviewboard.mozilla.org/r/115308/#review116772

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0026ce0ef66c
Update cubeb from upstream to 25b593f. r=padenot

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0026ce0ef66c

Comment 6

[Astley Chen (inactive)]

For regression bug 1340278, bug 1340289, could you please create uplift requests here so that we can incorporate the fixes into 52 beta for verification? Thanks.

Comment 7

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79b2c1781619

Comment 8

[Alex Chronopoulos [:achronop]]

Attachment: Uplift wasapi fixes in aurora

Approval Request Comment
[Feature/Bug causing the regression]: 
None

[User impact if declined]: 
Around 0.2% of browser crashes on 52.0b6

[Is this code covered by automated tests?]: yes

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: 
Small fix already in Nightly.

[String changes made/needed]: none

Comment 9

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1342363 - Uplift wasapi fixes in Aurora. r?kinetik

Approval Request Comment
[Feature/Bug causing the regression]: 
None

[User impact if declined]: 
Around 0.2% of browser crashes on 52.0b6

[Is this code covered by automated tests?]: yes

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: 
Small fix already in Nightly.

[String changes made/needed]: none

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8841517 [details] [diff] [review]
Bug 1342363 - Uplift wasapi fixes in Aurora. r?kinetik

Update for cubeb, let's uplift to aurora to see if it helps fix some crashes.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b05444b3fb44

Comment 12

[Astley Chen (inactive)]

Alex, it seems we still need an uplift request for *beta 52*. Could you help ?

Comment 13

[Alex Chronopoulos [:achronop]]

Sure, however please note bug 1337641 is not completed fixed by this one so uplift will not help there. In addition patch does not apply cleanly in 52, I have to check what's the different.

Comment 14

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=50ebacd6b2b2

Comment 15

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik

Approval Request Comment
[Feature/Bug causing the regression]: 
None

[User impact if declined]: 
Around 0.2% of browser crashes on 52.0b6

[Is this code covered by automated tests?]: yes

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: 
Small fix already in Nightly.

[String changes made/needed]: none

Comment 16

[Julien Cristau [:jcristau]]

It's too late for the 52 release.  Should we consider this as a ride along candidate in a possible dot release, or for inclusion in esr52?

Comment 17

[Alex Chronopoulos [:achronop]]

It would be good to consider it for ride along candidate and for inclusion in esr52.

Comment 18

[Julien Cristau [:jcristau]]

Comment on attachment 8842895 [details] [diff] [review]
Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik

See comment 15.

Comment 19

[Paul Adenot (:padenot)]

We need a couple more one liners that fix one or two more crashes. I'm landing those in nightly soon, and I'll look at crash stats to see if it worked.

Comment 20

[Sylvestre Ledru [:Sylvestre]]

Doesn't apply to release:

grafting 382424:0026ce0ef66c "Bug 1342363 - Update cubeb from upstream to 25b593f. r=padenot"
merging media/libcubeb/README_MOZILLA
merging media/libcubeb/src/cubeb_audiounit.cpp
merging media/libcubeb/src/cubeb_wasapi.cpp
warning: conflicts while merging media/libcubeb/README_MOZILLA! (edit, then use 'hg resolve --mark')
warning: conflicts while merging media/libcubeb/src/cubeb_audiounit.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging media/libcubeb/src/cubeb_wasapi.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 21

[Alex Chronopoulos [:achronop]]

For release you need to apply patch from comment 15, attached file: "Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik". From the output of the failure I believe you apply the inbound patch.

Comment 22

[Julien Cristau [:jcristau]]

Comment on attachment 8842895 [details] [diff] [review]
Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik

I'd rather leave this to 53.

Comment 23

[Julien Cristau [:jcristau]]

(In reply to Alex Chronopoulos [:achronop] from comment #21)
> For release you need to apply patch from comment 15, attached file: "Bug
> 1342363 - Uplift wasapi fixes to Beta. r?kinetik". From the output of the
> failure I believe you apply the inbound patch.

Yep, that's very likely what happened (I think Sylvestre was testing an automated tool that grafts changes from m-c to test uplifts).

Comment 24

[Julien Cristau [:jcristau]]

Comment on attachment 8842895 [details] [diff] [review]
Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik

cubeb fix for esr52

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/10285b4a6b71

Comment 26

[Andrei Vaida [:avaida]]

Setting qe-verify- based on Alex's assessment on manual testing needs (see Comment 15) and the fact that this fix has automated coverage.