Update cubeb from upstream to 25b593f

RESOLVED FIXED in Firefox -esr52

Status

()

defect
P1
normal
Rank:
15
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: achronop, Assigned: achronop)

Tracking

unspecified
mozilla54
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox51 wontfix, firefox52 wontfix, firefox-esr52 fixed, firefox53 fixed, firefox54 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Update cubeb from upstream to 25b593f. Commits log from previous import:

25b593f audiounit: Address issue #240 plus minor cleanups (#241)
3381056 Update AUTHORS
52c6093 audiounit: prevent deadlock by avoiding creating AU when getting channel layout
91c40d3 wasapi: fix two crashes (Bug 1340278, Bug 1340289)
4edf825 Allow to prebuffer more data when in debug.
Assignee: nobody → achronop
Rank: 15
Priority: -- → P1
Comment on attachment 8840879 [details]
Bug 1342363 - Update cubeb from upstream to 25b593f.

https://reviewboard.mozilla.org/r/115308/#review116772
Attachment #8840879 - Flags: review?(padenot) → review+
Pushed by achronop@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0026ce0ef66c
Update cubeb from upstream to 25b593f. r=padenot
Blocks: 1337641
Blocks: 1340291
Blocks: 1340278
https://hg.mozilla.org/mozilla-central/rev/0026ce0ef66c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Blocks: 1340970
For regression bug 1340278, bug 1340289, could you please create uplift requests here so that we can incorporate the fixes into 52 beta for verification? Thanks.
Flags: needinfo?(achronop)
Blocks: 1340289
Posted patch Uplift wasapi fixes in aurora (obsolete) — Splinter Review
Approval Request Comment
[Feature/Bug causing the regression]: 
None

[User impact if declined]: 
Around 0.2% of browser crashes on 52.0b6

[Is this code covered by automated tests?]: yes

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: 
Small fix already in Nightly.

[String changes made/needed]: none
Attachment #8841515 - Flags: review?(kinetik)
Attachment #8841515 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/Bug causing the regression]: 
None

[User impact if declined]: 
Around 0.2% of browser crashes on 52.0b6

[Is this code covered by automated tests?]: yes

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: 
Small fix already in Nightly.

[String changes made/needed]: none
Attachment #8841515 - Attachment is obsolete: true
Attachment #8841515 - Flags: review?(kinetik)
Attachment #8841515 - Flags: approval-mozilla-aurora?
Attachment #8841517 - Flags: review?(kinetik)
Attachment #8841517 - Flags: approval-mozilla-aurora?
Attachment #8841517 - Flags: review?(kinetik) → review+
Comment on attachment 8841517 [details] [diff] [review]
Bug 1342363 - Uplift wasapi fixes in Aurora. r?kinetik

Update for cubeb, let's uplift to aurora to see if it helps fix some crashes.
Attachment #8841517 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Alex, it seems we still need an uplift request for *beta 52*. Could you help ?
Sure, however please note bug 1337641 is not completed fixed by this one so uplift will not help there. In addition patch does not apply cleanly in 52, I have to check what's the different.
Approval Request Comment
[Feature/Bug causing the regression]: 
None

[User impact if declined]: 
Around 0.2% of browser crashes on 52.0b6

[Is this code covered by automated tests?]: yes

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: 
Small fix already in Nightly.

[String changes made/needed]: none
Flags: needinfo?(achronop)
Attachment #8842895 - Flags: review?(kinetik)
Attachment #8842895 - Flags: approval-mozilla-beta?
Attachment #8842895 - Flags: review?(kinetik) → review+
It's too late for the 52 release.  Should we consider this as a ride along candidate in a possible dot release, or for inclusion in esr52?
It would be good to consider it for ride along candidate and for inclusion in esr52.
Comment on attachment 8842895 [details] [diff] [review]
Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik

See comment 15.
Attachment #8842895 - Flags: approval-mozilla-release?
Attachment #8842895 - Flags: approval-mozilla-esr52?
Attachment #8842895 - Flags: approval-mozilla-beta?
We need a couple more one liners that fix one or two more crashes. I'm landing those in nightly soon, and I'll look at crash stats to see if it worked.
Doesn't apply to release:

grafting 382424:0026ce0ef66c "Bug 1342363 - Update cubeb from upstream to 25b593f. r=padenot"
merging media/libcubeb/README_MOZILLA
merging media/libcubeb/src/cubeb_audiounit.cpp
merging media/libcubeb/src/cubeb_wasapi.cpp
warning: conflicts while merging media/libcubeb/README_MOZILLA! (edit, then use 'hg resolve --mark')
warning: conflicts while merging media/libcubeb/src/cubeb_audiounit.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging media/libcubeb/src/cubeb_wasapi.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(achronop)
For release you need to apply patch from comment 15, attached file: "Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik". From the output of the failure I believe you apply the inbound patch.
Flags: needinfo?(achronop) → needinfo?(sledru)
Comment on attachment 8842895 [details] [diff] [review]
Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik

I'd rather leave this to 53.
Attachment #8842895 - Flags: approval-mozilla-release? → approval-mozilla-release-
(In reply to Alex Chronopoulos [:achronop] from comment #21)
> For release you need to apply patch from comment 15, attached file: "Bug
> 1342363 - Uplift wasapi fixes to Beta. r?kinetik". From the output of the
> failure I believe you apply the inbound patch.

Yep, that's very likely what happened (I think Sylvestre was testing an automated tool that grafts changes from m-c to test uplifts).
Flags: needinfo?(sledru)
Comment on attachment 8842895 [details] [diff] [review]
Bug 1342363 - Uplift wasapi fixes to Beta. r?kinetik

cubeb fix for esr52
Attachment #8842895 - Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
Setting qe-verify- based on Alex's assessment on manual testing needs (see Comment 15) and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.