1342531 - required signoffs are not accurate in scheduled changes in some cases

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P1)

Description

[[e-mail] (:bhearsum)]

While testing out bug 1310227, I found a couple of issues:
1) If you scheduled a change that will update a row to something that won't require signoff, but the current version of the row *does* require signoff, we never find required signoffs. 
2) We never find any required signoffs for deletes.

Both of these problems boil down to the fact that https://github.com/mozilla/balrog/blob/1bc8439bc7d4cf996738a069987f4a39d29f6edf/auslib/admin/views/scheduled_changes.py#L46 is only checking the scheduled change for required signoffs, not the current version of the row.

Comment 1

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #0)
> 2) We never find any required signoffs for deletes.

This is actually wrong, at least for the Rules case. We end up grabbing all possible required signoffs there, because "product" and "channel" are null in the scheduled change, which means all product required signoffs match.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: fix required signoffs being returned from scheduled changes api

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/2fb35857b6aa63723af07e966ba2b42dd7437de5
bug 1342531: required signoffs are not accurate in scheduled changes in some cases (#266). r=nthomas,jlorenzo

Comment 4

[[e-mail] (:bhearsum)]

This hit production today.