1342549 - DPR box shows very long number of decimal digits at certain zoom levels

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P3)

Description

[BoffinBrain]

Attachment: DPR box shows 14 digits after the decimal point

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170223185858

Steps to reproduce:

In cases where the device pixel ratio is not an integer, the new responsive design mode shows every single fractional digit, which is rather long and unnecessary! :)

Perhaps limit it to 3 D.P.

Comment 1

[BoffinBrain]

Probably related: Bug 1342549 - RDM-V2 - DPR box shows very long number of decimal digits at certain zoom levels

Comment 2

[BoffinBrain]

Ignore the above. See this instead: Bug 1325578 - DPR value is changed when zooming in or out when in RDM

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(Please don't set the priority yourself, it will hide the bug from triaging dashboards, and possibly get lost.)

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for the report!  I agree this could be improved.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1342549 - Trim RDM DPR to ~3 decimal places.

Review commit: https://reviewboard.mozilla.org/r/187086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187086/

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8915847 [details]
Bug 1342549 - Trim RDM DPR to ~3 decimal places.

https://reviewboard.mozilla.org/r/187086/#review193822

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb94e6ee9a4f
Trim RDM DPR to ~3 decimal places. r=gl

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/eb94e6ee9a4f