Closed Bug 1342549 Opened 7 years ago Closed 7 years ago

DPR box shows very long number of decimal digits at certain zoom levels

Categories

(DevTools :: Responsive Design Mode, defect, P3)

Product:
DevTools
Component:
Responsive Design Mode
Type:
defect

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: bugzilla, Assigned: jryans)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rdm-v2])

Attachments

(2 files)

DPR box shows 14 digits after the decimal point
19.51 KB, image/png
Details
Bug 1342549 - Trim RDM DPR to ~3 decimal places.
59 bytes, text/x-review-board-request
gl
: review+
Details 
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170223185858

Steps to reproduce:

In cases where the device pixel ratio is not an integer, the new responsive design mode shows every single fractional digit, which is rather long and unnecessary! :)

Perhaps limit it to 3 D.P.
Component: Untriaged → Developer Tools: Responsive Design Mode
Priority: -- → P3
Whiteboard: [rdm-v2]
Probably related: Bug 1342549 - RDM-V2 - DPR box shows very long number of decimal digits at certain zoom levels
Ignore the above. See this instead: Bug 1325578 - DPR value is changed when zooming in or out when in RDM
(Please don't set the priority yourself, it will hide the bug from triaging dashboards, and possibly get lost.)
Priority: P3 → --
Summary: RDM-V2 - DPR box shows very long number of decimal digits at certain zoom levels → DPR box shows very long number of decimal digits at certain zoom levels
Thanks for the report!  I agree this could be improved.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8915847 - Flags: review?(zer0) → review?(gl)
Comment on attachment 8915847 [details]
Bug 1342549 - Trim RDM DPR to ~3 decimal places.

https://reviewboard.mozilla.org/r/187086/#review193822
Attachment #8915847 - Flags: review?(gl) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/eb94e6ee9a4f
Trim RDM DPR to ~3 decimal places. r=gl
https://hg.mozilla.org/mozilla-central/rev/eb94e6ee9a4f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: