1342915 - normandy.isDefaultBrowser doesn't validate against FF set as default

Status: VERIFIED FIXED

(Firefox :: Normandy Client, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]
Having a recipe that has normandy.isDefaultBrowser as a filter should identify any FF that is set as the default browser as eligible to run the Shield recipe against.

[Prerequisites 1]: - for normandy staging
Open FF/ about:config and
1. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
2. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
3. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90.
4. Set extensions.shield-recipe-client.api_url to https://normandy-admin.stage.mozaws.net/api/v1

[Prerequisites]: - for running mock recipes
Open FF/ about:config and:
1. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
2. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
3. Set the security.content.signature.root_hash preference to 4C:35:B1:C3:E3:12:D9:55:E7:78:ED:D0:A7:E7:8A:38:83:04:EF:01:BF:FA:03:29:B2:46:9F:3C:C5:EC:36:04.
4.  Set extensions.shield-recipe-client.api_url to https://normandy-mock.dev.mozaws.net/FilterDefaultBrowser/api/v1


Steps:
1. Open a FF that has shield system addon and is not set as default. (at current time, Nightly and Aurora have)
2. Set the prerequisites.
3. From control center make sure you have a recipe that filters based on the fact that FF is set as default browser (normandy.isDefaultBrowser), if not create a recipe or use the mock recipe.
4. Open and check browser console output.
5. Set FF as default browser and restart FF.
6. Open and check browser console .

[Actual Result:]
4. + 6. In either of the cases, the recipe shall not be executed: the filter normandy.isDefaultBrowser will not return 1.

[Expected Result]:
4. The recipe (created from control center) or the mock recipe are not being fetched since the browser is not set as default.
6. Both the recipe (created from control server) and the mock recipe are executed since FF is the default browser.

Comment 1

[Osmose [:osmose, :mkelly]]

Github issue: https://github.com/mozilla/normandy/issues/539

Comment 2

[Osmose [:osmose, :mkelly]]

Patch landed in mozilla-central in the sync from bug 1349348. This will be deployed to Beta 53 and Release 53 as a system add-on (bug 1351454).

Comment 3

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on Beta53 across Ubuntu 16.04, Win10, OSX 10.12