1342920 - normandy.channel filter doesn't work

Status: RESOLVED FIXED

(Firefox :: Normandy Client, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]
Having a recipe that has normandy.channel as a filter should identify the FF channel is validated against, and for values as aurora or nightly it doesn't work at the moment.

[Prerequisites 1]: - for normandy staging
Open FF/ about:config and
1. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
2. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
3. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90.
4. Set extensions.shield-recipe-client.api_url to https://normandy-admin.stage.mozaws.net/api/v1

[Prerequisites 2]: - for running mock recipes
Open FF/ about:config and:
1. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
2. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
3. Set the security.content.signature.root_hash preference to 4C:35:B1:C3:E3:12:D9:55:E7:78:ED:D0:A7:E7:8A:38:83:04:EF:01:BF:FA:03:29:B2:46:9F:3C:C5:EC:36:04.
4.  Set extensions.shield-recipe-client.api_url to https://normandy-mock.dev.mozaws.net/FilterChannel/api/v1


Steps:
1. Open an aurora or a nightly FF that has shield system addon (at current time both Nightly and Aurora have)
2. Set the prerequisites.
3. From control center make sure you have a recipe that filters based on normandy.channel:  normandy.channel=='nightly' or normandy.channel=='aurora' , if not create a recipe that does or use the mock recipe.
4. Restart FF Nightly or Aurora and check browser console output. (based on the recipe expression filter or on the mock recipe)


[Actual Result:]
4. In either of the cases, the recipe shall not be executed: the filters are evaluated false (if there isn't some other issue in the midst of it)

[Expected Result]:
4. Both the recipe (created from control server) and the mock recipe are fetched and executed when FF version meets the filter.

Comment 1

[Osmose [:osmose, :mkelly]]

Github issue: https://github.com/mozilla/normandy/issues/540

Comment 2

[Osmose [:osmose, :mkelly]]

Patch landed in mozilla-central in the sync from bug 1349348. This will be deployed to Beta 53 and Release 53 as a system add-on (bug 1351454).

Comment 3

[Adrian Florinescu [:aflorinescu]]

Recipe that contained normandy.channel didn't match the beta version, but if I remember correctly, the current beta build might be a bit special. I will wait with this test until tomorrow, when beta 54 will be released.