Closed Bug 1342957 Opened 3 years ago Closed 3 years ago

MOZ_ASSERT(true) in AnimationEffectReadOnly::GetComputedTimingAt

Categories

(Core :: DOM: Animation, defect, minor)

51 Branch
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: bobowen, Assigned: boris)

References

Details

Attachments

(1 file)

:mak noticed this one when looking at bug 1342946, I assume this [1] should be MOZ_ASSERT(false, ...

[1] https://hg.mozilla.org/mozilla-central/file/106a96755d3b/dom/animation/AnimationEffectReadOnly.cpp#l237
Flags: needinfo?(boris.chiou)
Yes, you are right. We should fix this. Thanks for catching!
Flags: needinfo?(boris.chiou)
Assignee: nobody → boris.chiou
Comment on attachment 8841626 [details]
Bug 1342957 - Fix incorrect MOZ_ASSERT in AnimationEffectReadOnly.

https://reviewboard.mozilla.org/r/115782/#review117230
Attachment #8841626 - Flags: review?(hikezoe) → review+
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/682ee6f48027
Fix incorrect MOZ_ASSERT in AnimationEffectReadOnly. r=hiro
https://hg.mozilla.org/mozilla-central/rev/682ee6f48027
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.