Closed Bug 134311 Opened 22 years ago Closed 22 years ago

Don't hide "Publish" and "Save" menuitems

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: cmanske, Assigned: cmanske)

References

Details

(Whiteboard: [ADT3]publish, verify 129356 when this is fixed)

Attachments

(1 file)

Patch v1
1.93 KB, patch
Brade
: review+
darin.moz
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
I have been experimenting with hiding the "Save" menuitem when publishing a
remote URL, and hiding the "Publish" menuitem when editing local files to reduce
the number of items in the save+publish group in the File menu. 
Save brings up "Save As", and "Publish" bring up "Publish As" dialogs
(this redundancy is what make be want to simply hide them.)
But after discussions, the majority are not feeling very adventurous, so we should
stop hiding these menuitems that are allegedly commonly-expected by users.
Attached patch Patch v1 — — Splinter Review 
Don't hide the menu items. 
Also enables "Publish" when editing local files.
Status: NEW → ASSIGNED
Keywords: nsbeta1, patch, regression, review
Whiteboard: publish, FIX IN HAND, need r=,sr=
Target Milestone: --- → mozilla1.0
*** Bug 129356 has been marked as a duplicate of this bug. ***
Keywords: nsbeta1 → nsbeta1+
Whiteboard: publish, FIX IN HAND, need r=,sr= → publish, FIX IN HAND, need r=,sr= verify 129356 when this is fixed
Attachment #76856 - Flags: review+
Comment on attachment 76856 [details] [diff] [review]
Patch v1

r=brade if you add a comment to explain why we are checking for file scheme
(because we want to be able to publish and file may not be dirty)
Whiteboard: publish, FIX IN HAND, need r=,sr= verify 129356 when this is fixed → publish, FIX IN HAND, need sr= verify 129356 when this is fixed
This bug is critical to Publishing feature
Whiteboard: publish, FIX IN HAND, need sr= verify 129356 when this is fixed → [ADT2]publish, FIX IN HAND, need sr= verify 129356 when this is fixed
Comment on attachment 76856 [details] [diff] [review]
Patch v1

sr=darin, but how about removing the commented out code?
Attachment #76856 - Flags: superreview+
Keywords: adt1.0.0
Whiteboard: [ADT2]publish, FIX IN HAND, need sr= verify 129356 when this is fixed → [ADT2]publish, FIX IN HAND, reviewed, verify 129356 when this is fixed
adt1.0.0+ (on behalf of ADT) for checkin to the 1.0 trunk.

Changing impact to ADT3.
Keywords: adt1.0.0 → adt1.0.0+
Whiteboard: [ADT2]publish, FIX IN HAND, reviewed, verify 129356 when this is fixed → [ADT3]publish, FIX IN HAND, reviewed, verify 129356 when this is fixed
Comment on attachment 76856 [details] [diff] [review]
Patch v1

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #76856 - Flags: approval+
Whiteboard: [ADT3]publish, FIX IN HAND, reviewed, verify 129356 when this is fixed → [ADT3]publish, FIX IN HAND, approved, verify 129356 when this is fixed
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: adt1.0.0+, patch, regression, review
Resolution: --- → FIXED
Whiteboard: [ADT3]publish, FIX IN HAND, approved, verify 129356 when this is fixed → [ADT3]publish, verify 129356 when this is fixed
Verified on 04-05 trunk.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: