1343143 - Enable VP8 temporal scalability for simulcast

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Lee Ho]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161209094312

Steps to reproduce:

Configure the Firefox local SDP to enable VP8 simulcast encoding.


Actual results:

Firefox encodes VP8 simulcast streams with a single temporal layer.


Expected results:

Firefox should ideally encode VP8 simulcast streams with multiple temporal layers. Compare with Chrome, which uses three temporal layers when doing simulcast encoding for VP8. This is especially important for group video calls using an SFU architecture.

Comment 1

[Lee Ho]

This code review comment appears to be relevant:
https://bugzilla.mozilla.org/show_bug.cgi?id=1230197#c5

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

> Firefox should ideally encode VP8 simulcast streams with multiple temporal
> layers. Compare with Chrome, which uses three temporal layers when doing
> simulcast encoding for VP8. This is especially important for group video
> calls using an SFU architecture.

Actually the number of layers varies from 1 to 3, depending on resolution; see simulcast.cc in libjingle.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Sorry, that's number of simulcast layers; they are using 3 temporal layers for all simulcast layers it appears.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: enable 3 temporal layers in simulcast mode, at all resolutions

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afb2c11d61a53a414bf19414a47359b01870cf56 (with the fixes for TIAS and ssrc signaling as well).  Works fine locally, though we have nothing that would do anything interesting with temporal layers.  Reporter - can you try it with whatever it is you want it to work with?  Thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14aa512533f1
enable 3 temporal layers in simulcast mode, at all resolutions r=bwc

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/14aa512533f1