Intermittent browser/components/newtab/tests/browser/browser_PreviewProvider.js | Test timed out -

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: intermittent-bug-filer, Assigned: gbrown)

Tracking

({intermittent-failure})

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 disabled, firefox56 disabled)

Details

(Whiteboard: [stockwell disabled])

Attachments

(1 attachment)

Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Looks like this is failing only on Linux (but pretty frequently there), so I assume bug 1353542 just exposed an existing issue in the test. Forwarding the needinfo to ursula who reviewed this test, to decide if we she wants to debug it, or would prefer that we just disable it for Linux.
Flags: needinfo?(florian) → needinfo?(usarracini)
I say disable it, PreviewProvider was a module created for a project that is now dead, and the code isn't being used anywhere anymore. There are related bugs open right now to remove all the dead code for that project, so in the near future PreviewProvider.js won't exist anyways and the associated test will go away too.
Flags: needinfo?(usarracini)
Assignee

Comment 8

2 years ago
Thanks much for the discussion here. I'll disable this today.
Flags: needinfo?(gbrown)
Whiteboard: [stockwell needswork]

Comment 9

2 years ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f092789b33a
Skip browser_PreviewProvider.js on linux, for frequent time outs; r=me,test-only
Assignee

Updated

2 years ago
Flags: needinfo?(gbrown)
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]

Comment 10

2 years ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/648fe1aaa3ce
Fix non-standard manifest annotation; r=me,test-only
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
geoff: seems this is now back on windows, can you take a look or do we also need to disable on windows ?
Flags: needinfo?(gbrown)
Comment hidden (Intermittent Failures Robot)
Assignee

Comment 19

2 years ago
Based on comment 7, I'd say we should disable on Windows right away. Would you mind? (I'm away for a few more days.)
Flags: needinfo?(gbrown)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Assignee

Comment 23

2 years ago
Attachment #8879253 - Flags: review?(jmaher)
Attachment #8879253 - Flags: review?(jmaher) → review+

Comment 24

2 years ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2a7d992e956
Disable test_PreviewProvider.js on windows too; r=jmaher
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
This file is going to be removed in bug 1384977, and once that happens, this bug can be closed.
Depends on: 1384977
This bug should be gone now.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/projects/jamun/rev/8703bc363a5939852dfea4bebe87690950429f7b
Bug 1343150 - Disable test_PreviewProvider.js on windows too. r=jmaher, a=test-only
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Assignee: nobody → gbrown
You need to log in before you can comment on or make changes to this bug.