1343231 - Closing a tab will switch to the next tab numerically, not the most recently used tab

Status: RESOLVED FIXED

(Firefox for iOS :: General, enhancement, P1)

Description

[Simon Basca [:SimonB]]

Build: b2aff9d
iOS: 10.2
Device: iPad Air 2 

Steps to reproduce:
1. Open 3 tabs
2. In the second tab go to news.google.com
3. Tap on an article
4. Close the article

Actual results:
- After closing the article the focus will switch to the next tab, not the news.google.com page.

Expected results:
- After closing the article the focus should switch to the previous tab, news.google.com.

Note:
- When closing an article on Desktop the focus will switch to the previous tab.

Comment 1

[:garvan]

Dev note: check if the TabManager uses the Tab's date accessed to determine which tab to switch to when a tab is closed

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3127

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Merged into master.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v9.x

Comment 5

[Richard Newman [:rnewman]]

The fix in this bug was incorrect: it switches to tabs opened in the background with Open In New Tab, including ones the user has never viewed, and the behavior is now very different to desktop’s. I marked the regression bug as blocking this one.

Comment 6

[Richard Newman [:rnewman]]

Follow-up PR is in https://github.com/mozilla-mobile/firefox-ios/pull/3876.