1399872 - Wrong tab selected when closing tab

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Simon Basca [:SimonB]]

Build: 9.0(6017)
Device: iPad Air 2
iOS: 10.3.3

Steps to reproduce:
1. Load google.com in tab 1
2. Load news.google.com in tab 2
3. Load wikipedia.com in tab 3
4. Tap on the tab 2 (news.google.com) and tap on an article
        => The article opens in a new tab
5. Close the article

Actual results:
- The view will switch to the last loaded page.  

Expected results:
- The view should switch to the second tab(new.google.com) in this case because when we tap on an article it will open in a new tab. After closing the opened article we want to get back at the news.google.com page. This is the current behaviour on Safari. 
- In any other cases when closing a tab we should switch the view to the next numerical tab, not the last loaded page. Switching the view to the next numerical tab is the current behaviour in Safari, desktop or android. 

See video here:
- Behaviour in Safari: https://www.youtube.com/watch?v=elppF1u6j6U
- Behaviour in Firefox for iOS: https://www.youtube.com/watch?v=tLQCDEsgS5w

Note:
- This is a new issue that was introduced by Bug 1343231.

Comment 1

[Richard Newman [:rnewman]]

I’m a heavy multi-tab user, on both iPhone and iPad, and this bugs the heck out of me. A common workflow is:

- Open page 1 of some search results (e.g., “New Posts” on some web forum; page 1 of Reddit, whatever)
- Open a few interesting links in new tabs.
- Open page 2 in a new tab.
- Close page 1 and begin reading.

Expected:
- I can read through all of the interesting links I got through, then process page 2, just as one would on desktop.

Actual:
- Each time I close a tab, I end up on the last tab, and need to go to the tab switcher to get back to where I was.

This makes long-press “Close Tab” pretty useless to me much of the time.

Given that this is a regression in primary UI, I’m surprised this is a P3…

Comment 2

[Erica Wright [:ewright]]

Attachment: Pull Request