1343465 - The tab should show the "play tab" icon even the tab was muted.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Alastor Wu [:alwu]]

Fork from bug1338137 comment2.

The tab should show the "play tab" icon even the tab was muted.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1343465 - part1 : check audio track to decide the audible state when the media element was muted.

If the media starts after muting the tab, IsOwnerAudible() would always return
"eNotAudible". However, we don't show the "play tab" icon for the non-audible
element, so we can't dispatch the block-start event and show the "play tab".

Review commit: https://reviewboard.mozilla.org/r/116242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116242/

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1343465 - part2 : add test.

Review commit: https://reviewboard.mozilla.org/r/116244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116244/

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1343465 - part3 : move support files to the default area.

Review commit: https://reviewboard.mozilla.org/r/116258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116258/

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8842372 [details]
Bug 1343465 - part1 : check audio track to decide the audible state when the media element was muted.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116242/diff/1-2/

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8842373 [details]
Bug 1343465 - part2 : add test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116244/diff/1-2/

Comment 6

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc823b7f64db604f2a3584e5bcca1b540254dd0e

Comment 7

[Andrea Marchesini [:baku]]

Comment on attachment 8842372 [details]
Bug 1343465 - part1 : check audio track to decide the audible state when the media element was muted.

https://reviewboard.mozilla.org/r/116242/#review118916

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8842373 [details]
Bug 1343465 - part2 : add test.

https://reviewboard.mozilla.org/r/116244/#review118918

Comment 9

[Andrea Marchesini [:baku]]

Comment on attachment 8842377 [details]
Bug 1343465 - part3 : move support files to the default area.

https://reviewboard.mozilla.org/r/116258/#review118920

Comment 10

[Alastor Wu [:alwu]]

Comment on attachment 8842372 [details]
Bug 1343465 - part1 : check audio track to decide the audible state when the media element was muted.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116242/diff/2-3/

Comment 11

[Alastor Wu [:alwu]]

Comment on attachment 8842373 [details]
Bug 1343465 - part2 : add test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116244/diff/2-3/

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 8842377 [details]
Bug 1343465 - part3 : move support files to the default area.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116258/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05312b954500
part1 : check audio track to decide the audible state when the media element was muted. r=baku
https://hg.mozilla.org/integration/autoland/rev/60d90be2e7bc
part2 : add test. r=baku
https://hg.mozilla.org/integration/autoland/rev/f0989ac3ad80
part3 : move support files to the default area. r=baku

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/05312b954500
https://hg.mozilla.org/mozilla-central/rev/60d90be2e7bc
https://hg.mozilla.org/mozilla-central/rev/f0989ac3ad80