134360 - classic: subscribe dialog/mail filters is missing dot/checkmark to un/subscribe to newsgroups.

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P1)

Description

[[not reading bugmail]]

seen in build 3-29-16 w2k.. build 3-27-03 is fine.  regression.

no checkboxes are present.

there should be checkboxes present.

Comment 1

[[not reading bugmail]]

this has an outliner and checkboxes together.. so a listbox problem?

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Subscribe is mail/news, not browser-general.  And yes, I see this with build
2002-3-30-09, with Classic only.  Modern is fine.  Win2k.

Comment 3

[[not reading bugmail]]

It was mail/news component when I switched it to subscribe.


taking... I have a PM patch that fixes this, its classic subscribe.css that
needed fixing.. tested and works.

Comment 4

[[not reading bugmail]]

Attachment: patch v1.0 -diff

my first patch, this was an easy one to fix, but took me some time to figure
out why, and how to fix it.

stephen, can I get a r= ?

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 76939 [details] [diff] [review]
patch v1.0  -diff

r=[e-mail].

I patched, build, and tested the changes.  We're now back to the dot/checkmark
with this patch, on classic.  Thanks for fixing this.  Please email
[e-mail] and ask for sr=.

Comment 6

[[not reading bugmail]]

thanks stephen, updating summary for real problem, not checkboxes, but
dot/checkmark in the classic skin is not shown.  I guess I should have checked
the mark to re-assign the bug to you when I switched it to subscribe.

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 76939 [details] [diff] [review]
patch v1.0  -diff

sr=sspitzer

Comment 8

[Olav Vitters]

*** Bug 134485 has been marked as a duplicate of this bug. ***

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 76939 [details] [diff] [review]
patch v1.0  -diff

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 10

[[not reading bugmail]]

stephen, re-assigning back to you.

can you check this in for me.. 

thanks.

Comment 11

[[not reading bugmail]]

Attachment: another patch to fix filterDialog.css for Classic skin.. same problem

needed to fix syntax of properties as mailfilters do not show dot/checkmark
also.



stephen.  can I get another r=	another PM patch.

Comment 12

[[not reading bugmail]]

update summary to add mail/filters.

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 77073 [details] [diff] [review]
another patch to fix filterDialog.css for Classic skin.. same problem

r=[e-mail]

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 77073 [details] [diff] [review]
another patch to fix filterDialog.css for Classic skin.. same problem

sr=sspitzer

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 77073 [details] [diff] [review]
another patch to fix filterDialog.css for Classic skin.. same problem

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 16

[scottputterman]

adt1.0.0+ per ADT.

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 134750 has been marked as a duplicate of this bug. ***

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

C:\moz_src\mozilla\themes\classic\messenger>cvs commit -m "Bug 134360. classic:
mail filters are missing checkbox icons. Patch by Dennis <[e-mail]>
r=[e-mail], sr=[e-mail],
a=[e-mail], adt=[e-mail]" filterDialog.css
Checking in filterDialog.css;
/cvsroot/mozilla/themes/classic/messenger/filterDialog.css,v  <--  filterDialog.css
new revision: 1.3; previous revision: 1.2
done

Comment 19

[Olav Vitters]

*** Bug 134826 has been marked as a duplicate of this bug. ***

Comment 20

[laurel]

Looks OK in classic theme using apr4 commercial trunk build: win98, mac OS 10.1,
linux rh6.2

Comment 21

[laurel]

added verified branch keyword. Even though it was verified on trunk before
branch (and never got a fixed1.0.0),  checked again on apr17 1.0.0 branch
commercial build win98.  Getting it off radar.