1343665 - Remove pref layout.css.object-fit-and-position.enabled

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

We've been shipping object-fit & object-position default-enabled for years now (as of bug 1099450).

Unlikely that we'd want to un-ship it at this point  Let's remove the pref.

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: part 1: remove all mentions from source & tests

Comment 2

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: part 2: regenerate devtools db

Comment 3

[Daniel Holbert [:dholbert] (PTO until 2/24)]

A few notes on part 1:

 - I'm ignoring the "DO NOT EDIT!" disclaimers at the top of reftest-stylo.list files. Manishearth says this is fine & that the disclaimer is largely obsolete, especially for mechanical changes like this.

 - I'm updating my "generate-object-fit-*-tests.sh" scripts [which I originally wrote to generate the object-fit & object-position tests & manifests, & which I checked in at dbaron's request) -- they mention this pref in their reftest.list-generating boilerplate, and I'm updating them to remove that from the boilerplate.  (Not so much because I care about keeping these scripts up-to-date -- mostly just because I don't want there to be any DXR/grep hits for the pref name after this bug is done.)

 - In property_database.js, this is purely a code-move (except for the first and last line of each chunk, which is changing from...
  "gCSSProperties["object-fit"] = {
     [...]
  };
...to:
  "object-fit": {
     [...]
  },

Comment 4

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: part 1, v2: remove all mentions from source & tests

Sorry, the first version of "part 1" didn't compile, because these properties had CSS_PROPERTY_ENABLED_IN_UA_SHEETS in nsCSSPropList.h, which is meaningless once they're not pref-controlled.  And we (helpfully!) have some build-time checks to complain about that.

So, this updated version removes those CSS_PROPERTY_ENABLED_IN_UA_SHEETS usages as well.

Comment 5

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Green try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=acae4b40dce5ce69e67b6d15723cc7376f49ec0e

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8842619 [details] [diff] [review]
part 2: regenerate devtools db

r=mats

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c9b2a4ecc28
part 1: Remove all mentions of about:config pref "layout.css.object-fit-and-position.enabled" from source files. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/18f657821f93
part 2: Regenerate devtools' generated properties db, now that layout.css.object-fit-and-position.enabled is removed. r=mats

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0c9b2a4ecc28
https://hg.mozilla.org/mozilla-central/rev/18f657821f93