Remove pref layout.css.object-fit-and-position.enabled

RESOLVED FIXED in Firefox 54

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

We've been shipping object-fit & object-position default-enabled for years now (as of bug 1099450).

Unlikely that we'd want to un-ship it at this point  Let's remove the pref.
Attachment #8842618 - Flags: review?(mats)
Attachment #8842619 - Flags: review?(mats)
A few notes on part 1:

 - I'm ignoring the "DO NOT EDIT!" disclaimers at the top of reftest-stylo.list files. Manishearth says this is fine & that the disclaimer is largely obsolete, especially for mechanical changes like this.

 - I'm updating my "generate-object-fit-*-tests.sh" scripts [which I originally wrote to generate the object-fit & object-position tests & manifests, & which I checked in at dbaron's request) -- they mention this pref in their reftest.list-generating boilerplate, and I'm updating them to remove that from the boilerplate.  (Not so much because I care about keeping these scripts up-to-date -- mostly just because I don't want there to be any DXR/grep hits for the pref name after this bug is done.)

 - In property_database.js, this is purely a code-move (except for the first and last line of each chunk, which is changing from...
  "gCSSProperties["object-fit"] = {
     [...]
  };
...to:
  "object-fit": {
     [...]
  },
Sorry, the first version of "part 1" didn't compile, because these properties had CSS_PROPERTY_ENABLED_IN_UA_SHEETS in nsCSSPropList.h, which is meaningless once they're not pref-controlled.  And we (helpfully!) have some build-time checks to complain about that.

So, this updated version removes those CSS_PROPERTY_ENABLED_IN_UA_SHEETS usages as well.
Attachment #8842618 - Attachment is obsolete: true
Attachment #8842618 - Flags: review?(mats)
Attachment #8842632 - Flags: review?(mats)
Depends on: 1099450
Attachment #8842632 - Flags: review?(mats) → review+
Comment on attachment 8842619 [details] [diff] [review]
part 2: regenerate devtools db

r=mats
Attachment #8842619 - Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c9b2a4ecc28
part 1: Remove all mentions of about:config pref "layout.css.object-fit-and-position.enabled" from source files. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/18f657821f93
part 2: Regenerate devtools' generated properties db, now that layout.css.object-fit-and-position.enabled is removed. r=mats
https://hg.mozilla.org/mozilla-central/rev/0c9b2a4ecc28
https://hg.mozilla.org/mozilla-central/rev/18f657821f93
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.