1343830 - Remove browser/themes/windows/loop

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P3)

Description

[Florian Quèze [:florian]]

These 2 files don't seem to be used anywhere:

browser/themes/windows/loop/toolbar-win10.png
browser/themes/windows/loop/[e-mail]

And when looking at https://hg.mozilla.org/mozilla-central/rev/f579b4fc5bf5, it seems these files have never actually been packaged, and the files we actually used for Hello were at:

browser/extensions/loop/skin/windows/toolbar-win10.png
browser/extensions/loop/skin/windows/[e-mail]

Comment 1

[Ganesh Chaitanya Kale]

Hi Dao,

I would like to work on this bug. Please let me know how to proceed on this.

Regards
Ganesh

Comment 2

[Dão Gottwald [:dao]]

(In reply to ganesh2583 from comment #1)
> Hi Dao,
> 
> I would like to work on this bug. Please let me know how to proceed on this.
> 
> Regards
> Ganesh

Basically you just need to do 'hg rm browser/themes/windows/loop'

Comment 3

[Ganesh Chaitanya Kale]

Attachment: Patch for Bug 1343830

Hi,

I added the fix patch for this bug. Please review the changes and let me know if anything else is required.

Regards,
Ganesh

Comment 4

[Ganesh Chaitanya Kale]

Hi Dao,

Can you also point me any other bugs where I can contribute more, from coding and application understanding perspective. My skill set include JavaScript, Java and HTML/CSS. I would like to contribute more on that front.

Regards,
Ganesh

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8849572 [details] [diff] [review]
Patch for Bug 1343830

This patch seems broken. It says "Binary file [...] has changed" (without listing any change) rather than "deleted file mode 100644".

Comment 6

[Ganesh Chaitanya Kale]

(In reply to Dão Gottwald [::dao] from comment #5)
> Comment on attachment 8849572 [details] [diff] [review]
> Patch for Bug 1343830
> 
> This patch seems broken. It says "Binary file [...] has changed" (without
> listing any change) rather than "deleted file mode 100644".

I think since the files inside the folder are .png files the patch shows are Binary Files. I did 'hg rm browser/themes/windows/loop' as well as from Hg Workbench I removed the folder, that is how the patch is getting generated in both the cases. Please let me know if you think otherwise.

Comment 7

[Dão Gottwald [:dao]]

Yes, it's in binary format, but the deletions aren't noted correctly. It doesn't just look wrong, I also tried to apply the patch locally and it didn't do anything :/

Comment 8

[Ganesh Chaitanya Kale]

Attachment: Attached the correct patch now.

I generate the previous patch from Hg Workbench. May be that was causing the issue. I not generate the patch using "hg export tip > "Bug 1343830.patch"" command. And the patch files seems to have the content you have mentioned. Please let me if any further changes are required.

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8849611 [details] [diff] [review]
Attached the correct patch now.

Looks good :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e428a9ba3f
Remove browser/themes/windows/loop. r=dao

Comment 11

[Ganesh Chaitanya Kale]

(In reply to Dão Gottwald [::dao] from comment #9)
> Comment on attachment 8849611 [details] [diff] [review]
> Attached the correct patch now.
> 
> Looks good :)

Hey,

I think this message got lost in the disturbance, let me copy paste again :

Can you also point me any other bugs where I can contribute more, from coding and application understanding perspective. My skill set include JavaScript, Java and HTML/CSS. I would like to contribute more on that front.

:-)

Comment 12

[Dão Gottwald [:dao]]

(In reply to ganesh2583 from comment #11)
> Can you also point me any other bugs where I can contribute more, from
> coding and application understanding perspective. My skill set include
> JavaScript, Java and HTML/CSS. I would like to contribute more on that front.
> 
> :-)

Here's another one that I just filed: bug 1349502. It's not particularly complex but slightly more interesting than this one.

Comment 13

[Ganesh Chaitanya Kale]

(In reply to Dão Gottwald [::dao] from comment #12)
> (In reply to ganesh2583 from comment #11)
> > Can you also point me any other bugs where I can contribute more, from
> > coding and application understanding perspective. My skill set include
> > JavaScript, Java and HTML/CSS. I would like to contribute more on that front.
> > 
> > :-)
> 
> Here's another one that I just filed: bug 1349502. It's not particularly
> complex but slightly more interesting than this one.

Cool, let me comment on that bug to get started on it.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a2e428a9ba3f