1343845 - bug status summary does not work when logged out

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: Readable Bug Statuses, defect)

Description

[:glob ✱]

steps to reproduce:

1. load any bug 1319452 while logged in
2. observe the status has "Status (bug RESOLVED as FIXED for Firefox 53)"
3. load the same bug in a private browsing window or after logging out

expected:

"Status (bug RESOLVED as FIXED for Firefox 53)"

actual:

"Status ()"

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Look at console to see what, if any errors are happening.

Comment 2

[:glob ✱]

sorry, should have mentioned it in my initial report - there's no js errors in the console.

Comment 3

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

The function to generate the readable status message never executes:

extensions/BugModal/web/bug_modal.js: lines 778-780

var rbs = $("#readable-bug-status");
var rbs_text = bugzillaReadableStatus.readable(rbs.data('readable-bug-status'));
rbs.text(rbs_text);

It is in a section of code which never executes unless there's a valid login session.

At line 452 in the same file:

if (BUGZILLA.user.id === 0) return;

I'll attempt a patch and see what breaks if I move those three lines up;

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: Patch

GitHub pull request.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8845235 [details] [review]
Patch

git commit --amend the commit, the commit message should be in the form that comes out of the "Copy tp clipboard" button the bug page.

The subsequent lines can have any format

Comment 6

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Updated the commit message.

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8845235 [details] [review]
Patch

r=dylan, will commit soon

Comment 8

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   dfb694156..badbd7739  master -> master