1343914 - 'Sync devices' field will be incorrectly displayed when switching between panels

Status: VERIFIED FIXED

(Firefox for iOS :: Home screen, defect, P3)

Description

[Simon Basca [:SimonB]]

Build: c63f81b1
Device: iPhone 6
iOS: 9.3.5

Pre-requisite: 
- At least 2 devices synced with the same FxA

Steps to reproduce:
1. Go to History panel
2. Go to Bookmark panel 
3. Continue repeating steps 1) and 2) 

Actual results: 
- 'Sync devices' field will be incorrectly displayed.

See video: https://www.youtube.com/watch?v=JbFoCp-eRe8

Comment 1

[Farhan Patel [:farhan]]

Thats actually the "2 device(s) connected" text being animated in. 
When the panel first loads the text in the cell is just "Synced Devices" so it appears centered in the cell. When the subtitle text is added there is an animation which moves the title up in order to center both the title and subtitle correctly.

Because we query how many devices are connected after the panel loads theres an animation that occurs when the text is added.

Comment 3

[Aaron Train [:aaronmt]]

I filed bug 1353480 because this looks really odd. I think we can do better.

Comment 4

[Isabel Rios[:isabel_rios]]

I agree with Aaron, from user point of view, although the functionality is not broken it looks weird, not very 'clean'

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3190

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Merged into master.

Comment 8

[Simon Basca [:SimonB]]

Verifying as fix on master 90c97d6ec7.

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v9.x

Comment 10

[Simon Basca [:SimonB]]

Verifying as fix on 9.1(6241).