1344018 - Add front-end interface to retrigger actions

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Description

[William Lachance (:wlach)]

This bug will track adding the ability to execute custom taskcluster actions on jobs from treeherder, in support of bug 1343327.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1344018 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8843049 [details] [review]
[treeherder] wlach:1344018 > mozilla:master

This is actually getting pretty close. I wouldn't mind some feedback on the taskcluster parts of tcjobactions.js  before I actually put this up for review. There are some things that are still a little ambiguous to me (see the comments marked "fixme").

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8843049 [details] [review]
[treeherder] wlach:1344018 > mozilla:master

Ok, I'm feeling pretty happy about this now. I might tweak some small things in response to jonas and brian's feedback but I figured I might as well put this up for review. I'd rather not delay rolling this out, as it's eagerly anticipated (we can always tweak more later).

Comment 4

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8843049 [details] [review]
[treeherder] wlach:1344018 > mozilla:master

See review coments on github:
https://github.com/mozilla/treeherder/pull/2220

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8843049 [details] [review]
[treeherder] wlach:1344018 > mozilla:master

I'll clear camd's review while I look into making things closer to what jonasfj suggests.

Comment 6

[William Lachance (:wlach)]

Looks like jonasfj's rendering code depends on some features that are only in lodash 4.x. I guess it's a good a time as any to look into upgrading...

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8843049 [details] [review]
[treeherder] wlach:1344018 > mozilla:master

Jonas, could you have another look? I think this should address your concerns.

Comment 8

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8843049 [details] [review]
[treeherder] wlach:1344018 > mozilla:master

It's missing filtering on the `kind` property which is specified in spec, but not in the actions.json file we release.
Patching fixing this and adding the `kind` property is in bug 1345660.

Comment 9

[William Lachance (:wlach)]

> It's missing filtering on the `kind` property which is specified in spec,
> but not in the actions.json file we release.
> Patching fixing this and adding the `kind` property is in bug 1345660.

I will fix this.

Comment 10

[William Lachance (:wlach)]

Comment on attachment 8843049 [details] [review]
[treeherder] wlach:1344018 > mozilla:master

Ok, I think is ready for review now.

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a45f2d3c48c0b6e79fe26609d1599558ad91c44d
Bug 1344018 - Add ability to execute custom taskcluster actions per job (#2220)

Comment 12

[William Lachance (:wlach)]

I think we can call this done. We can always do additional work in followups.