1344079 - Add webrender support for ColumnRule

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

For the first round DisplayItem Conversion, we should add WR support for ColumnRule.

Comment 1

[Peter Chang[:pchang]]

ColumnRule uses nsDisplayGenericOverflow[1] for painting instead of using its own display item. If we want to convert ColumnRule into Webrender commands, we need a display item. Therefore, I think we have two options.

a. create nsDisplayColumnRule that is derived from nsDisplayGenericOverflow in nsColumnRuleSetFrame
b. replace nsDisplayGenericOVerflow to nsDisplayColumnRule because no one uses this class except ColumnRule and it is very simple


Matt, any suggestion?

[1]http://searchfox.org/mozilla-central/source/layout/generic/nsColumnSetFrame.cpp#1132
[2]http://searchfox.org/mozilla-central/source/layout/painting/nsDisplayList.h#2714

Comment 2

[Peter Chang[:pchang]]

I prefer option b, because option a just adds another new displayItem which makes displayitem sustain more difficult.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Option b sounds great to me!

Comment 4

[Peter Chang[:pchang]]

Wait for try result

https://treeherder.mozilla.org/#/jobs?repo=try&revision=924445500a89d57eb2cebd97377158053036d24a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa9df11b7f1cec0fc4cf0af942d850530b6639a9

Comment 5

[Peter Chang[:pchang]]

Attachment: Bug 1344079 - Convert ColumnRule to WebRenderDisplayItemLayer,

Review commit: https://reviewboard.mozilla.org/r/123790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123790/

Comment 6

[Peter Chang[:pchang]]

fix the assertion error and second run try looks good.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fab631932ee584f6457f46fa9a8179d069b34214&selectedJob=86568225
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab8464ad2d8108bffac99e221e76a835a806b2ff&selectedJob=86568192

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8851479 [details]
Bug 1344079 - Convert ColumnRule to WebRenderDisplayItemLayer,

https://reviewboard.mozilla.org/r/123790/#review130186

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 71723dc055e7 -d c8193c2ac137: rebasing 388237:71723dc055e7 "Bug 1344079 - Convert ColumnRule to WebRenderDisplayItemLayer, r=mattwoodrow" (tip)
merging gfx/thebes/gfxPrefs.h
merging layout/painting/nsDisplayList.h
warning: conflicts while merging gfx/thebes/gfxPrefs.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[Peter Chang[:pchang]]

Comment on attachment 8851479 [details]
Bug 1344079 - Convert ColumnRule to WebRenderDisplayItemLayer,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123790/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23b50bbed022
Convert ColumnRule to WebRenderDisplayItemLayer, r=mattwoodrow

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23b50bbed022