Closed Bug 1344079 Opened 3 years ago Closed 3 years ago

Add webrender support for ColumnRule

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ethlin, Assigned: pchang)

References

Details

Attachments

(1 file)

For the first round DisplayItem Conversion, we should add WR support for ColumnRule.
Blocks: 1342343
Component: DOM: Workers → Graphics: WebRender
Assignee: ethlin → howareyou322
ColumnRule uses nsDisplayGenericOverflow[1] for painting instead of using its own display item. If we want to convert ColumnRule into Webrender commands, we need a display item. Therefore, I think we have two options.

a. create nsDisplayColumnRule that is derived from nsDisplayGenericOverflow in nsColumnRuleSetFrame
b. replace nsDisplayGenericOVerflow to nsDisplayColumnRule because no one uses this class except ColumnRule and it is very simple


Matt, any suggestion?

[1]http://searchfox.org/mozilla-central/source/layout/generic/nsColumnSetFrame.cpp#1132
[2]http://searchfox.org/mozilla-central/source/layout/painting/nsDisplayList.h#2714
Flags: needinfo?(matt.woodrow)
I prefer option b, because option a just adds another new displayItem which makes displayitem sustain more difficult.
Option b sounds great to me!
Flags: needinfo?(matt.woodrow)
Comment on attachment 8851479 [details]
Bug 1344079 - Convert ColumnRule to WebRenderDisplayItemLayer,

https://reviewboard.mozilla.org/r/123790/#review130186
Attachment #8851479 - Flags: review?(matt.woodrow) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 71723dc055e7 -d c8193c2ac137: rebasing 388237:71723dc055e7 "Bug 1344079 - Convert ColumnRule to WebRenderDisplayItemLayer, r=mattwoodrow" (tip)
merging gfx/thebes/gfxPrefs.h
merging layout/painting/nsDisplayList.h
warning: conflicts while merging gfx/thebes/gfxPrefs.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by pchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23b50bbed022
Convert ColumnRule to WebRenderDisplayItemLayer, r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/23b50bbed022
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.