Closed Bug 1344211 Opened 3 years ago Closed 3 years ago

Reader view shortcut not listed in menu

Categories

(Toolkit :: Reader Mode, defect, P2)

51 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jens.b, Assigned: aryx)

References

Details

Attachments

(1 file)

The shortcut key introduced by bug 1144749 is not listed in the menu (at least on the Mac, didn't test other platforms).

To find it, you need to search the web: it is documented in the Firefox 50 release notes.
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Comment on attachment 8843343 [details]
Bug 1344211 - Reader view shortcut should be shown in 'View' menu.

https://reviewboard.mozilla.org/r/117110/#review118724

::: browser/base/content/browser-menubar.inc:300
(Diff revision 1)
>                            type="checkbox"
>                            observes="View:FullScreen"/>
>  #endif
>                  <menuitem id="menu_readerModeItem"
>                            observes="View:ReaderView"
> +                          key="toggleReaderMode"

Can you prefix this correctly (ie in browser-sets.inc as well as here) like all the other keys?

With that, r=me
Attachment #8843343 - Flags: review?(gijskruitbosch+bugs) → review+
See Also: → 1344284
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/9c177d80ee84
Reader view shortcut should be shown in 'View' menu. r=Gijs
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/9c177d80ee84
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.