Reader view shortcut not listed in menu

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Reader Mode
P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Jens Bannmann, Assigned: aryx)

Tracking

51 Branch
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
The shortcut key introduced by bug 1144749 is not listed in the menu (at least on the Mac, didn't test other platforms).

To find it, you need to search the web: it is documented in the Firefox 50 release notes.

Updated

4 months ago
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Comment hidden (mozreview-request)

Comment 2

4 months ago
mozreview-review
Comment on attachment 8843343 [details]
Bug 1344211 - Reader view shortcut should be shown in 'View' menu.

https://reviewboard.mozilla.org/r/117110/#review118724

::: browser/base/content/browser-menubar.inc:300
(Diff revision 1)
>                            type="checkbox"
>                            observes="View:FullScreen"/>
>  #endif
>                  <menuitem id="menu_readerModeItem"
>                            observes="View:ReaderView"
> +                          key="toggleReaderMode"

Can you prefix this correctly (ie in browser-sets.inc as well as here) like all the other keys?

With that, r=me
Attachment #8843343 - Flags: review?(gijskruitbosch+bugs) → review+
(Reporter)

Updated

4 months ago
See Also: → bug 1344284
Comment hidden (mozreview-request)

Comment 4

4 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/9c177d80ee84
Reader view shortcut should be shown in 'View' menu. r=Gijs
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED

Comment 5

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9c177d80ee84
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.