1344284 - Reader mode menu item not always visible

Status: NEW

(Toolkit :: Reader Mode, defect, P3)

Description

[Jens Bannmann]

For some web pages, the location bar icon for 'reader mode' does not appear (presumably because no article content could be identified), which is okay.
 
However, the item in the "View" menu is also invisible in this case, which is unusual for menu items. Instead, the menu item should appear disabled, as is the case for e.g. the "Bookmarks > Subscribe to this page..." menu item.

This helps educate users about the existence of the feature and (via bug 1344211) about its keyboard shortcut.

Comment 1

[Evan Tseng [:evanxd]]

Looks like the issue already fixed by Bug 1344211, right?

Comment 2

[Jens Bannmann]

(In reply to Evan Tseng [:evanxd] from comment #1)
> Looks like the issue already fixed by Bug 1344211, right?

No, why should it? That bug was about including the shortcut key in the menu item, whereas this bug is about the visibility of the menu item as a whole.

I don't see any code change in the fix to bug 1344211 that would alter the behavior when the menu item is shown or not. Specifically, I imagine that the hidden="true" attribute of the menu item (see below) would have to be removed and the corresponding code for hiding/showing to be changed to disabling/enabling.

> browser/base/content/browser-menubar.inc
>
>  <menuitem id="menu_readerModeItem"
>            observes="View:ReaderView"
>            key="key_toggleReaderMode"
>            hidden="true"/>