Fix ESLint issues in devtools/client/memory/test/chrome/*.html

RESOLVED FIXED in Firefox 63

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: ntim, Assigned: harry7)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
Firefox 63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

Reporter

Description

2 years ago
No description provided.
Reporter

Comment 1

2 years ago
Posted patch WIPSplinter Review
Priority: -- → P3
Reporter

Updated

2 years ago
Keywords: good-first-bug
Summary: Fix ESLint for files ignored by bug 1342144 → Fix ESLint for devtools files ignored by bug 1342144
Hi,
I would like to work on this bug. Can you assign this to me. Also can someone guide me on what is to be done and where I should start looking at?
Thanks,
Flags: needinfo?(ntim.bugs)
Reporter

Comment 3

Last year
(In reply to Hemanth Kumar Veeranki [:harry7] from comment #2)
> Hi,
> I would like to work on this bug. Can you assign this to me. Also can
> someone guide me on what is to be done and where I should start looking at?
> Thanks,


[0] provides a list of ignored files by ESLint in the devtools/ folder. 

Steps:
- Run `./mach eslint --no-ignore ` followed by one of the lines in [0]
- Once you do this, you will get a list of JS errors/warnings, you will need to fix them one by one.
- Once you're done fixing the errors, you can remove the relevant line in [0].

Note that you don't need to do all the lines from [0] in the same bug. Feel free to only fix a couple of lines.

[0]: https://dxr.mozilla.org/mozilla-central/source/.eslintignore#104-125
Assignee: nobody → hems.india1997
Flags: needinfo?(ntim.bugs)

Updated

Last year
Product: Firefox → DevTools
(In reply to Tim Nguyen :ntim from comment #3)

> Steps:
> - Run `./mach eslint --no-ignore ` followed by one of the lines in [0]
When I ran the following command with one of the files, I am getting an error like this
> mach: error: unrecognized arguments for lint: '--no-ignore'

I am not able to proceed further. What should I do next?
Flags: needinfo?(ntim.bugs)
I ran eslint like `./mach lint -l eslint` instead of `./mach eslint` and it worked.
Thanks
Flags: needinfo?(ntim.bugs)
Reporter

Updated

Last year
Attachment #8985769 - Flags: review?(ntim.bugs) → review?(gtatum)

Comment 7

11 months ago
mozreview-review
Comment on attachment 8985769 [details]
Bug 1344286 - Fix eslint errors from devtools files ignored previously;

https://reviewboard.mozilla.org/r/251310/#review262504

All the changes look correct to me, I'm running a try run now to verify. Thanks for the patch!
Attachment #8985769 - Flags: review?(gtatum) → review+
Reporter

Comment 8

11 months ago
You might want to remove https://searchfox.org/mozilla-central/source/.eslintignore#104 before landing :)
Flags: needinfo?(gtatum)
Woops, can you do that :harry7? And then needinfo me and I'll re-run the the try server and try to land this.
Flags: needinfo?(gtatum)
Reporter

Updated

11 months ago
Flags: needinfo?(hems.india1997)
Comment hidden (mozreview-request)
Assignee

Comment 11

11 months ago
(In reply to Greg Tatum [:gregtatum] [@gregtatum] from comment #9)
> Woops, can you do that :harry7? And then needinfo me and I'll re-run the the
> try server and try to land this.

Thanks :gregtatum I added that change to the commit and pushed it for review. Should I continue doing these changes in different commits? so that the commit won't become too large?
Assignee

Updated

11 months ago
Flags: needinfo?(hems.india1997) → needinfo?(gtatum)
Reporter

Comment 12

11 months ago
mozreview-review
Comment on attachment 8985769 [details]
Bug 1344286 - Fix eslint errors from devtools files ignored previously;

https://reviewboard.mozilla.org/r/251310/#review262556

The new ESLint push looks green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=320db4ee1c3181579e84be23b2067fc758308545

along with Greg's earlier push (https://treeherder.mozilla.org/#/jobs?repo=try&revision=d716c042b99de2b566df0ebf11695f36298f2396) where devtools tests were green.

Thanks for working on this!
Attachment #8985769 - Flags: review?(ntim.bugs) → review+
Reporter

Updated

11 months ago
Summary: Fix ESLint for devtools files ignored by bug 1342144 → Fix ESLint issues in devtools/client/memory/test/chrome/*.html

Comment 13

11 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/34ff21c524d4
Fix eslint errors from devtools files ignored previously; r=gregtatum,ntim

Comment 14

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/34ff21c524d4
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Thanks Hemanth!
Flags: needinfo?(gtatum)
You need to log in before you can comment on or make changes to this bug.