Turn off buildbot static analysis jobs on linux64 debug and macosx64 debug

RESOLVED FIXED

Status

Release Engineering
Buildduty
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: kats, Assigned: spacurar)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

In bug 1264494 I added taskcluster jobs for the static-analysis builds for linux64 debug and macosx64 debug platforms. These jobs were previously running with buildbot, so now they are running with both. We can stop running them in buildbot once that change propagates around to the various branches.

Specific examples of the jobs can be seen at [1] and [2]. Note that it's only the *debug* jobs that are running on buildbot, the opt ones are already taskcluster'd.

Also note that once the buildbot version has been decommissioned, we can remove the block at [3] as we won't be exercising that mozconfig on a Darwin machine.

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e150eaff1f83e4e4a97d1e30c57d233859efe9cb&selectedJob=80883243
[2] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e150eaff1f83e4e4a97d1e30c57d233859efe9cb&selectedJob=80877978
[3] https://hg.mozilla.org/integration/autoland/file/fdf438735657/browser/config/mozconfigs/macosx64/debug-static-analysis#l5
Bug 1264494 has made it to mozilla-central. So the old buildbot jobs can be turned off on inbound, autoland, and mozilla-central. Presumably once m-c merges to mozilla-aurora (sometime today or tomorrow) it can be turned off there as well.
(Reporter)

Updated

8 months ago
Blocks: 1342450
(Assignee)

Updated

8 months ago
Assignee: nobody → spacurar
Is this just a matter of ripping out all the -st-an stuff from https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py ? If so I can write a patch to do that. I have no idea how to test it though :/
(Assignee)

Comment 3

8 months ago
Created attachment 8845476 [details] [diff] [review]
bug_1344297.patch
Attachment #8845476 - Flags: review?(kmoir)
(Assignee)

Comment 4

8 months ago
Created attachment 8845477 [details]
diff

I disabled static analysis builds for oak branch as well, because they already run on task cluster

Comment 5

8 months ago
Comment on attachment 8845476 [details] [diff] [review]
bug_1344297.patch

I think you can remove 

mc_gecko_version = BRANCHES['mozilla-central']['gecko_version']

too since it's not used by other stanzas.  

You also need a patch to remove the mozconfig stanza that kats mentioned in the original comment

[3] https://hg.mozilla.org/integration/autoland/file/fdf438735657/browser/config/mozconfigs/macosx64/debug-static-analysis#l5

This patch will have to land after the reconfig for the first patch, to ensure that all running jobs have completed.
Attachment #8845476 - Flags: review?(kmoir) → review+
Comment on attachment 8845476 [details] [diff] [review]
bug_1344297.patch

https://hg.mozilla.org/build/buildbot-configs/rev/3c4f5edd47eb
https://hg.mozilla.org/build/buildbot-configs/rev/bf139a6884f9

Landed the patch with the above mentioned observation.
Attachment #8845476 - Flags: checked-in+
(Assignee)

Comment 7

7 months ago
Created attachment 8845811 [details] [diff] [review]
bug_1344297_mozconfig.patch
Attachment #8845811 - Flags: review?(kmoir)

Updated

7 months ago
Attachment #8845811 - Flags: review?(kmoir) → review+
The buildbot changes seem to have taken effect and have stopped producing builds. AFAICT we should be able to land the mozconfig change and close out this bug.

Comment 9

7 months ago
Pushed by aselagea@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7f6a6b8ee9c
Turn off buildbot static analysis jobs on linux64 debug and macosx64 debug, r=kmoir
(Assignee)

Updated

7 months ago
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED

Comment 10

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a7f6a6b8ee9c
You need to log in before you can comment on or make changes to this bug.