Revert e10s addons rollout to only addons with mpc=true or webextensions, and remove whitelist support

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Extension Compatibility
P1
normal
RESOLVED FIXED
2 months ago
23 days ago

People

(Reporter: shell, Assigned: Felipe, NeedInfo)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 verified, firefox53 fixed, firefox54 fixed, firefox55 fixed)

Details

(Whiteboard: [go-faster-system-addon])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Reporter)

Description

2 months ago
reset everyone to MPC=true and webextensions to get e10s on beta and release. (desired result is to stop giving e10s based on current allowlist)

block Lastpass support@lastpass.com in release (Lastpass should NOT be blocked on beta).

Tab mix plus removed from blocked on Beta - plan to do update to system add-on on release after ~3 weeks of beta data. i'd be fine with removing from all blocklists based on author input, author fixed issue that we blocked them for and controls their flag.  But since it's a bigger add-on, believe release mgmt would be happier if test in beta first.  We can update "allow list" then as well based on additional telemetry data.
(Reporter)

Comment 1

2 months ago
Hi Felipe, Do you know when this one will go out?
(Reporter)

Comment 2

2 months ago
Please also add Mega firefox@mega.co.nz to not receive e10s

Updated

2 months ago
Whiteboard: [go-faster-system-addon]
(Reporter)

Updated

2 months ago
Depends on: 1344273
(Assignee)

Comment 3

a month ago
Created attachment 8848332 [details] [diff] [review]
patch_for_release

Ok, so this was a bit tricky due to the version numbers. Here's the scoop:

51 shipped e10srollout version 1.7
52 shipped e10srollout version 1.9
central/aurora/beta has version 1.11

So what I'm doing is I'm gonna bump the version of the xpi to 1.12 to make sure it updates on both 51 and 52. And then in the trees we can bump it to 1.15 when we work on the bug to implement the new whitelist with the no-shims addons
Attachment #8848332 - Flags: review?(mconley)
Comment on attachment 8848332 [details] [diff] [review]
patch_for_release

Review of attachment 8848332 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, let's do it. Thanks felipe!
Attachment #8848332 - Flags: review?(mconley) → review+
(Assignee)

Comment 5

a month ago
Created attachment 8848562 [details]
e10srollout@mozilla.org-1.12-ff5152.xpi, unsigned

Hi Jason, can you sign this for me?
Attachment #8848562 - Flags: feedback?(jthomas)
(Reporter)

Comment 6

a month ago
Thanks Felipe =].  Just FYI - the change I expect coming up to the whitelists will only be to remove tab mix plus from blocklist to get e10s.

Kev replied to the email on what to do about add-ons not using shims (potential future whitelist).  Since getting them to webextensions is the only solution beyond 56, we are not going to do a whitelist for the interim.  SDK add-ons could have perf issues with multi on release, so we're just going to bypass that potential churn of whitelisting these and focus on the clear message of going to webextensions.
Created attachment 8849168 [details]
e10srollout@mozilla.org-1.12-ff5152.xpi signed

Please see attached.
(Reporter)

Comment 8

a month ago
need info'ing myself to follow up 3 weeks after landing (so we have time to get telemetry and feedback from Beta users) to unblock tab mix plus and lastpass in releases.
Flags: needinfo?(sescalante)
Pinging rares for QA. We also need an "Intent to Ship" email[0] for RelMan approval (shell?).

[0] https://wiki.mozilla.org/Firefox/Go_Faster/System_Add-ons/Process#Intent_to_Ship_and_RelMan_Approval
Flags: needinfo?(rares.macarie)

Updated

a month ago
Attachment #8848562 - Flags: feedback?(jthomas)
(Assignee)

Comment 10

a month ago
To test this:

1 - Run a fresh profile of Firefox 51 or 52 and make sure e10s is running
2 - Install YouTube Downloader and restart
3 - Make sure e10s is still running
4 - Install the signed add-on attached in this bug
5 - Restart _twice_
6 - Check that e10s is now blocked for addons (in about:support)

Comment 11

a month ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d572929cc182
Revert e10s addons rule to only activate on mpc=true and webextensions. r=mconley
(Assignee)

Updated

a month ago
Keywords: leave-open
Summary: Firefox 51 and 52 e10s targeting → Revert e10s addons rollout to only addons with mpc=true or webextensions, and remove whitelist support

Comment 12

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d572929cc182

Comment 13

a month ago
Following the steps from the comment 10 I tested with:
- Adblock Plus https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/?src=hp-dl-mostpopular
- Youtube Best Video Downloader 2 https://addons.mozilla.org/en-US/firefox/addon/youtube-download-mp3-mp4-1080p/?src=search  
on Firefox 51.0-build2-win32 (en-US) and 52.0.1-build2-win64 (en-US)under Wind 7 64-bit. 

At step 3 - Make sure e10s is still running, the e10s is (Disabled by add-ons).

I am not sure why this is happening but on the latest Firefox 55.0a1 the e10s remains enabled at step 3.
Do you have any ideea why this is happening Felipe Gomes?
Flags: needinfo?(rares.macarie) → needinfo?(felipc)
(In reply to CosminB from comment #13)
> At step 3 - Make sure e10s is still running, the e10s is (Disabled by
> add-ons).
> 
> I am not sure why this is happening but on the latest Firefox 55.0a1 the
> e10s remains enabled at step 3.
> Do you have any ideea why this is happening Felipe Gomes?
FWIW this system add-on is only targeting 51 and 52 in Balrog. Does 55 need to be in the test plan?

Comment 15

a month ago
(In reply to Cory Price [:ckprice] from comment #14)
> (In reply to CosminB from comment #13)
> > At step 3 - Make sure e10s is still running, the e10s is (Disabled by
> > add-ons).
> > 
> > I am not sure why this is happening but on the latest Firefox 55.0a1 the
> > e10s remains enabled at step 3.
> > Do you have any ideea why this is happening Felipe Gomes?
> FWIW this system add-on is only targeting 51 and 52 in Balrog. Does 55 need
> to be in the test plan?

I used 55 as a basis of comparison since on 51 and 52 the e10s is not working as expected.
(Assignee)

Comment 16

a month ago
The problem was that the add-on used here was not a good one. There are various "Youtube Downloader" add-ons and didn't specify which was the right one that was whitelisted.

Here's a good one to use: https://addons.mozilla.org/en-US/firefox/addon/colorpicker/?src=ss

To test, you can follow the steps on comment 10 and install _only_ this addon on step 2.

I did test this myself though and I'm pretty confident it works as expected.
Flags: needinfo?(felipc)
This is on release.
Comment hidden (mozreview-request)

Comment 19

29 days ago
mozreview-review
Comment on attachment 8852076 [details]
Bug 1344345 - Revert e10s addons rule to only activate on mpc=true and webextensions, now for the Beta channel too.

https://reviewboard.mozilla.org/r/124318/#review127050

Why are the aushelper files being removed here?
(Assignee)

Comment 20

29 days ago
mozreview-review-reply
Comment on attachment 8852076 [details]
Bug 1344345 - Revert e10s addons rule to only activate on mpc=true and webextensions, now for the Beta channel too.

https://reviewboard.mozilla.org/r/124318/#review127050

Ugh this wasn't supposed to be here. Let me fix the commit.
Comment hidden (mozreview-request)

Comment 22

29 days ago
mozreview-review
Comment on attachment 8852076 [details]
Bug 1344345 - Revert e10s addons rule to only activate on mpc=true and webextensions, now for the Beta channel too.

https://reviewboard.mozilla.org/r/124318/#review127064

Looks good, thanks!
Attachment #8852076 - Flags: review?(mconley) → review+

Comment 23

29 days ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b94530a2e66c
Revert e10s addons rule to only activate on mpc=true and webextensions, now for the Beta channel too. r=mconley
(Assignee)

Comment 24

29 days ago
Firefox 51 and 52 were fixed by pushing this through GoFaster, and for 53 and onwards I'll request uplift of this patch
status-firefox52: --- → fixed
Keywords: leave-open
(Assignee)

Comment 25

29 days ago
Comment on attachment 8848332 [details] [diff] [review]
patch_for_release

Approval Request Comment
[Feature/Bug causing the regression]: reverting some of the e10s-addons exposure to remove the whitelist of addons
[User impact if declined]: Users will continue to use e10s when there are whitelisted non-mpc=true add-ons, which we no longer want because they use shims
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: It has no effect on Nightly
[Needs manual test from QE? If yes, steps to reproduce]: Verified by QA and pushed via GoFaster to release users on 51 and 52
[List of other uplifts needed for the feature/fix]: the other patch in this bug
[Is the change risky?]: no
[Why is the change risky/not risky?]: already QA'ed and deployed to 51 and 52, and it reverts the e10s configuration to what was shipped on 50.
[String changes made/needed]: none
Attachment #8848332 - Flags: approval-mozilla-beta?
Attachment #8848332 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 26

29 days ago
Comment on attachment 8852076 [details]
Bug 1344345 - Revert e10s addons rule to only activate on mpc=true and webextensions, now for the Beta channel too.

Approval Request Comment
Same as above.  The first patch is to configure release users, and this one is to configure beta users, to use the setting "only mpc=true or webextensions"
Attachment #8852076 - Flags: approval-mozilla-beta?
Attachment #8852076 - Flags: approval-mozilla-aurora?

Comment 27

28 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b94530a2e66c
Status: NEW → RESOLVED
Last Resolved: 28 days ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment on attachment 8848332 [details] [diff] [review]
patch_for_release

Let's get 53 in the same state as 53 for e10s enabled addons.
Attachment #8848332 - Flags: approval-mozilla-beta?
Attachment #8848332 - Flags: approval-mozilla-beta+
Attachment #8848332 - Flags: approval-mozilla-aurora?
Attachment #8848332 - Flags: approval-mozilla-aurora+
Attachment #8852076 - Flags: approval-mozilla-beta?
Attachment #8852076 - Flags: approval-mozilla-beta+
Attachment #8852076 - Flags: approval-mozilla-aurora?
Attachment #8852076 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 29

27 days ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/8617040db92d
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e9f8edcfdca 

https://hg.mozilla.org/releases/mozilla-beta/rev/21f7a3a22c61
https://hg.mozilla.org/releases/mozilla-beta/rev/35f6dba39a27
status-firefox53: --- → fixed
status-firefox54: affected → fixed
(Assignee)

Comment 30

27 days ago
So, to summarize:

This was fixed through a system add-on update shipped to 51.* and 52.* users, and fixed in-tree for 53 and up.

Comment 31

25 days ago
(In reply to :shell escalante from comment #2)
> Please also add Mega firefox@mega.co.nz to not receive e10s

Why that? I thought that after bug 1046053 and bug 1189385 it was fine?

Comment 32

23 days ago
Based on the comment 10, I tested the Firefox 51 and 52 builds using the add-on from the comment 16.
All the builds have passed the tests, as you can see in https://public.etherpad-mozilla.org/p/1344345.

This issue is verified as fixed on Firefox 52.0.2 (20170323105023) under Wind 7 64-bit, Ubuntu 12.04 64-bit and Mac OS X 10.12.1
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.