134447 - [classic]Visual improvement request for tabs and dialog buttons

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[spamittomebaby]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.9) Gecko/20020310
BuildID:    2002031005 (0.9.9)

The line below the tabs should be aqua-blue instead of white. The font, used in
tabs and dialog buttons, should be bold.

Reproducible: Always
Steps to Reproduce:
n/a

Actual Results:  The line below the tabs is white. Fonts, used in tabs and
buttons, are regular, instead of bold font.

Expected Results:  The line below the tabs should be blue in my opinion. 

On an OS X system, open "Network Utility" for example. This program has some
tabs with a blue line just below the tabs. It's just a minor thing, but I think
Mozilla looks a lot more OSX native when this line is blue. 

When it's not too much trouble, the font, used in the tabs and buttons in
dialogs, should be bold.

Comment 1

[Ari]

I have a patch to fix the following tab issues:
1. The gray rectangle surrounding the tabs (patch to tabbox.css)
2. The bar at the top of the tab pane is disabled (white) instead of enabled
(blue) (patch to nsNativeTheme.cpp)

One problem remains. The tabs still look disconnected from the tab panels
because the tab panel appears to be painted on top of the tabs. As a result, the
shadow from the panel is covering the part of the tabs that is supposed to look
connected to the panel.

BTW: I think the font problem isn't going to be fixed until we get ATSUI font
rendering.

Comment 2

[Ari]

Attachment: patch to tabbox.css

Comment 3

[Ari]

Attachment: preliminary patch to nsNativeThemeMac

Comment 4

[Mike Pinkerton (not reading bugmail)]

haha, good catch on the logic reversal. i guess i should take this bug, hewitt's
busy with other stuff.

Comment 5

[Mike Pinkerton (not reading bugmail)]

the button text problem is covered under bug 134643. regardless, please limit
bug submissions to one issue per bug.

Comment 6

[Mike Pinkerton (not reading bugmail)]

should i try to at least get these two patches landed? i tested them and they
look great.

Comment 7

[Warren TenBrook]

Looks like my unconfirmed Bug 131243 may be a dup of this assigned bug, even
though 131243 preceded.  Don't know if this is just bad karma or a problem with
my 131243 report.

Comment 8

[Mike Pinkerton (not reading bugmail)]

*** Bug 131243 has been marked as a duplicate of this bug. ***

Comment 9

[Ari]

You might as well try to land these because they are an improvement. I still
want to investigate the fact that the tabs are being drawn under the tab panel.
I think this is a problem on winxp as well. What controls the layering of ui
elements?

Comment 10

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 78510 [details] [diff] [review]
patch to tabbox.css

r=pink

Comment 11

[David Hyatt]

sr=hyatt

Comment 12

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 78511 [details] [diff] [review]
preliminary patch to nsNativeThemeMac

r=pink

Comment 13

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 78510 [details] [diff] [review]
patch to tabbox.css

really sr=hyatt

Comment 14

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 78511 [details] [diff] [review]
preliminary patch to nsNativeThemeMac

really sr=hyatt

Comment 15

[Mike Pinkerton (not reading bugmail)]

fixed on trunk. asking mom for branch permission.

Comment 16

[Paul Wyskoczka]

adt1.0.0+ on behalf of the adt.  Please check into the branch today and add
fixed1.0.0 to the keyword field.

Comment 17

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 78510 [details] [diff] [review]
patch to tabbox.css

a=[e-mail]

Comment 18

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 78511 [details] [diff] [review]
preliminary patch to nsNativeThemeMac

a=[e-mail]

Comment 19

[Randell Jesup [:jesup] (needinfo me)]

Posthumous a= granted.  Next time, ask for it first....

Comment 20

[Patty Mac]

Verified the patch both in branch and commercial trunk builds.