Closed Bug 1344732 Opened 7 years ago Closed 7 years ago

The "Show tabs from other devices" panel looks awful

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox53 --- unaffected
firefox54 --- fixed
firefox55 --- verified

People

(Reporter: ehsan.akhgari, Assigned: eoger)

References

Details

Attachments

(9 files)

Attached image Screenshot
See the screenshot.
Maybe a regression from bug 1228478?
Dorel already has bug 1344129 on his plate, here's a quick fixup.
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8844124 [details]
Bug 1344732 - Don't hardcode width/height in sync-illustration.svg.

https://reviewboard.mozilla.org/r/117668/#review119352

Rubber-stamp LGTM! For poserity, could you upload a screenshot with the fix, please?
Attachment #8844124 - Flags: review?(kit) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55243aaba0c8
Don't hardcode width/height in sync-illustration.svg. r=kitcambridge
(In reply to Edouard Oger [:eoger] from comment #5)
> Created attachment 8844128 [details]
> Screen Shot 2017-03-06 at 3.09.55 PM.png

Does this also fix the bug when the panel is attached to the toolbar button, as it was for me?
We still need some CSS touchups for the button I think
OK, so can you please file a follow-up for those?  Thanks!  :-)
Attached image ff51.png
Update: it was already messed up before!
So this bug fixed the regression correctly.
I'll open a new one for this. Thank you.
https://hg.mozilla.org/mozilla-central/rev/55243aaba0c8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Status-firefox55 : Verified & PARTIALLY FIXED

The "Show tabs from other devices" panel - still incorrect when opening from Menu.

refer the screenshot attached.
[bugday-20170308] With reference to above comment.
As others noted, this is still not fixed.  I'm gonna reopen this bug since the patch landed didn't fix the bug that I filed and the follow-up bug I asked for to fix what I filed was never filed.  ;-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The bug has been filed (bug 1344900), but it was not a follow-up since this is not a regression, we never actually noticed the bug (but it's been there for a while now).
I'll take care of the Windows-specific problem Madhuri noted.
Attached image win10.png
Madhuri,

Can you tell me more about the build and the operating system you were using for that test? Are you sure you were using the latest nightly?
I just tried on Windows 10 and couldn't reproduce (see attachment).
Flags: needinfo?(madhuri.mittal99)
FWIW, I also can't reproduce this on Win 7, even with non-default DPI settings.
Attached image 1344732_updated.png
I was testing on BuildID : 20170307030205 for which I had attached the screenshot that the bug was still there.

After updating Nightly with the new updates available today, the bug seems to be fixed now. Please refer the latest attached screenshot.
(In reply to Edouard Oger [:eoger] from comment #16)
> Created attachment 8845095 [details]
> win10.png
> 
> Madhuri,
> 
> Can you tell me more about the build and the operating system you were using
> for that test? Are you sure you were using the latest nightly?
> I just tried on Windows 10 and couldn't reproduce (see attachment).

Ya sure. I was testing on BuildID : 20170307030205 with windows 10. Please refer my comment#18. The bug seems to be fixed now with the latest updates.
Thank you for the confirmation Madhuri
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: needinfo?(madhuri.mittal99)
Resolution: --- → FIXED
(In reply to Edouard Oger [:eoger] from comment #20)
> Thank you for the confirmation Madhuri

You welcome.

Status-firefox-55.0a1 : VERIFIED & FIXED.

BuildID : 20170308030207
firefox-55.0a1(2017-03-08)(32 bit) 
OS: windows 10 Pro (64 bit)
Status: RESOLVED → VERIFIED
Comment on attachment 8844124 [details]
Bug 1344732 - Don't hardcode width/height in sync-illustration.svg.

Approval Request Comment
[Feature/Bug causing the regression]: 1228478
[User impact if declined]: The Synced Tabs menu will look completely broken
[Is this code covered by automated tests?]: it's css changes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: not at all
[Why is the change risky/not risky?]: it's only css changes and we manually tested this.
[String changes made/needed]: no
Attachment #8844124 - Flags: approval-mozilla-aurora?
Comment on attachment 8844124 [details]
Bug 1344732 - Don't hardcode width/height in sync-illustration.svg.

Polish an UI issue and was verified. Aurora54+.
Attachment #8844124 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attached image Untitled.png
[Budday - 20170315]
OS: Windows 10.0
Browser: 55.0a1
Its seem the bug still not fixed well in latest version.
This bug concerned the "Tab Syncing disabled" view, which is not what I'm seeing on your screenshot.
Please feel free to re-open if you have more information.
[bugday-20170329] - managed to reproduce this issue with given below platform and build ID, its no longer reproducible.

status-ff55 : FIXED & VERIFIED.

OS : Win10X64

FF-Nightly : 55.0a1(2017-03-28)(32 bit)

BuildID : 20170328095415
[bugday-20170329]

status-ff55 : FIXED & VERIFIED.

Managed to reproduce the issue on Firefox Nightly(affected build ID : 20170307030205), under Windows 10 X 64.

The issue is no longer reproducible on Firefox latest Nightly [BuildID : 20170328095415 , 55.0a1(2017-03-28)(32 bit)]. 
Tests were performed under Windows 10 X 64.
[bugday-20170329]
The statues of the issue is fixed, hence verified in nightly 55.0a1(64 bit)
OS: Windows 10.0 X 64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: