Closed
Bug 1344732
Opened 7 years ago
Closed 7 years ago
The "Show tabs from other devices" panel looks awful
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
firefox55 | --- | verified |
People
(Reporter: ehsan.akhgari, Assigned: eoger)
References
Details
Attachments
(9 files)
70.58 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
lina
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
89.27 KB,
image/png
|
Details | |
67.30 KB,
image/png
|
Details | |
31.79 KB,
image/png
|
Details | |
122.91 KB,
image/png
|
Details | |
62.04 KB,
image/png
|
Details | |
26.69 KB,
image/png
|
Details | |
162.96 KB,
image/png
|
Details |
See the screenshot.
Comment 1•7 years ago
|
||
Maybe a regression from bug 1228478?
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Dorel already has bug 1344129 on his plate, here's a quick fixup.
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8844124 [details] Bug 1344732 - Don't hardcode width/height in sync-illustration.svg. https://reviewboard.mozilla.org/r/117668/#review119352 Rubber-stamp LGTM! For poserity, could you upload a screenshot with the fix, please?
Attachment #8844124 -
Flags: review?(kit) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/55243aaba0c8 Don't hardcode width/height in sync-illustration.svg. r=kitcambridge
Reporter | ||
Comment 7•7 years ago
|
||
(In reply to Edouard Oger [:eoger] from comment #5) > Created attachment 8844128 [details] > Screen Shot 2017-03-06 at 3.09.55 PM.png Does this also fix the bug when the panel is attached to the toolbar button, as it was for me?
Assignee | ||
Comment 8•7 years ago
|
||
We still need some CSS touchups for the button I think
Reporter | ||
Comment 9•7 years ago
|
||
OK, so can you please file a follow-up for those? Thanks! :-)
Assignee | ||
Comment 10•7 years ago
|
||
Update: it was already messed up before! So this bug fixed the regression correctly. I'll open a new one for this. Thank you.
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/55243aaba0c8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 12•7 years ago
|
||
Status-firefox55 : Verified & PARTIALLY FIXED The "Show tabs from other devices" panel - still incorrect when opening from Menu. refer the screenshot attached.
Comment 13•7 years ago
|
||
[bugday-20170308] With reference to above comment.
Reporter | ||
Comment 14•7 years ago
|
||
As others noted, this is still not fixed. I'm gonna reopen this bug since the patch landed didn't fix the bug that I filed and the follow-up bug I asked for to fix what I filed was never filed. ;-)
Reporter | ||
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 15•7 years ago
|
||
The bug has been filed (bug 1344900), but it was not a follow-up since this is not a regression, we never actually noticed the bug (but it's been there for a while now). I'll take care of the Windows-specific problem Madhuri noted.
Assignee | ||
Comment 16•7 years ago
|
||
Madhuri, Can you tell me more about the build and the operating system you were using for that test? Are you sure you were using the latest nightly? I just tried on Windows 10 and couldn't reproduce (see attachment).
Flags: needinfo?(madhuri.mittal99)
Comment 17•7 years ago
|
||
FWIW, I also can't reproduce this on Win 7, even with non-default DPI settings.
Comment 18•7 years ago
|
||
I was testing on BuildID : 20170307030205 for which I had attached the screenshot that the bug was still there. After updating Nightly with the new updates available today, the bug seems to be fixed now. Please refer the latest attached screenshot.
Comment 19•7 years ago
|
||
(In reply to Edouard Oger [:eoger] from comment #16) > Created attachment 8845095 [details] > win10.png > > Madhuri, > > Can you tell me more about the build and the operating system you were using > for that test? Are you sure you were using the latest nightly? > I just tried on Windows 10 and couldn't reproduce (see attachment). Ya sure. I was testing on BuildID : 20170307030205 with windows 10. Please refer my comment#18. The bug seems to be fixed now with the latest updates.
Assignee | ||
Comment 20•7 years ago
|
||
Thank you for the confirmation Madhuri
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Flags: needinfo?(madhuri.mittal99)
Resolution: --- → FIXED
Comment 21•7 years ago
|
||
(In reply to Edouard Oger [:eoger] from comment #20) > Thank you for the confirmation Madhuri You welcome. Status-firefox-55.0a1 : VERIFIED & FIXED. BuildID : 20170308030207 firefox-55.0a1(2017-03-08)(32 bit) OS: windows 10 Pro (64 bit)
Assignee | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 22•7 years ago
|
||
Comment on attachment 8844124 [details] Bug 1344732 - Don't hardcode width/height in sync-illustration.svg. Approval Request Comment [Feature/Bug causing the regression]: 1228478 [User impact if declined]: The Synced Tabs menu will look completely broken [Is this code covered by automated tests?]: it's css changes [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: [Is the change risky?]: not at all [Why is the change risky/not risky?]: it's only css changes and we manually tested this. [String changes made/needed]: no
Attachment #8844124 -
Flags: approval-mozilla-aurora?
Comment 23•7 years ago
|
||
Comment on attachment 8844124 [details] Bug 1344732 - Don't hardcode width/height in sync-illustration.svg. Polish an UI issue and was verified. Aurora54+.
Attachment #8844124 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 24•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/a5f9b43013e6
Comment 25•7 years ago
|
||
Updated•7 years ago
|
Comment 26•7 years ago
|
||
[Budday - 20170315] OS: Windows 10.0 Browser: 55.0a1 Its seem the bug still not fixed well in latest version.
Assignee | ||
Comment 27•7 years ago
|
||
This bug concerned the "Tab Syncing disabled" view, which is not what I'm seeing on your screenshot. Please feel free to re-open if you have more information.
Comment 28•7 years ago
|
||
[bugday-20170329] - managed to reproduce this issue with given below platform and build ID, its no longer reproducible. status-ff55 : FIXED & VERIFIED. OS : Win10X64 FF-Nightly : 55.0a1(2017-03-28)(32 bit) BuildID : 20170328095415
Comment 29•7 years ago
|
||
[bugday-20170329] status-ff55 : FIXED & VERIFIED. Managed to reproduce the issue on Firefox Nightly(affected build ID : 20170307030205), under Windows 10 X 64. The issue is no longer reproducible on Firefox latest Nightly [BuildID : 20170328095415 , 55.0a1(2017-03-28)(32 bit)]. Tests were performed under Windows 10 X 64.
Comment 30•7 years ago
|
||
[bugday-20170329] The statues of the issue is fixed, hence verified in nightly 55.0a1(64 bit) OS: Windows 10.0 X 64
You need to log in
before you can comment on or make changes to this bug.
Description
•