Closed Bug 1344829 Opened 3 years ago Closed 3 years ago

add BUG_COMPONENT to security/* files

Categories

(Core :: Security: PSM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

to ensure bugs get to the right component, we want to map all the source files in-tree to the proper bugzilla components.

I have this figured out:
$ ./mach file-info bugzilla-component security/**
Core :: Build Config
  security/generate_certdata.py
  security/generate_mapfile.py
Core :: Security: PSM
  security/apps
  security/certverifier
  security/manager
  security/moz.build
  security/nss
  security/nss.symbols
  security/patches
  security/pkix
Core :: Security: Process Sandboxing
  security/sandbox



I am confused about security/nss/* and security/patches/*, these seem to be nss imported code from (https://hg.mozilla.org/projects/nss), if we find code that is problematic here, should we file bugs in security:psm, or nss:??
Attached patch add BUG_COMPONENT to security/* (obsolete) — Splinter Review
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8844108 - Flags: review?(dkeeler)
> I am confused about security/nss/* and security/patches/*, these seem to be nss imported code from (https://hg.mozilla.org/projects/nss), if we find code that is problematic here, should we file bugs in security:psm, or nss:??

Yep. For NSS at least. Patches isn't really used afaik.
Comment on attachment 8844108 [details] [diff] [review]
add BUG_COMPONENT to security/*

Review of attachment 8844108 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. We should probably just remove the patches directory.
Attachment #8844108 - Flags: review?(dkeeler) → review+
(In reply to Joel Maher ( :jmaher) from comment #0)
> code that is problematic here, should we file bugs in security:psm, or nss:??

NSS :: Libraries would probably be best.
updated nss to be NSS:Libraries and removed the security/patches/ directory:

$ ./mach file-info bugzilla-component security/**
Core :: Build Config
  security/generate_certdata.py
  security/generate_mapfile.py
Core :: Security: PSM
  security/apps
  security/certverifier
  security/manager
  security/moz.build
  security/pkix
Core :: Security: Process Sandboxing
  security/sandbox
NSS :: Libraries
  security/nss
  security/nss.symbols

with those few changes, I thought it best to ask for a r? again.
Attachment #8844108 - Attachment is obsolete: true
Attachment #8844828 - Flags: review?(dkeeler)
Comment on attachment 8844828 [details] [diff] [review]
add BUG_COMPONENT to security/* and remove patches/ dir

Review of attachment 8844828 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, LGTM.
Attachment #8844828 - Flags: review?(dkeeler) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aad8e9c4a511
add BUG_COMPONENT to security/* files. r=keeler
https://hg.mozilla.org/mozilla-central/rev/aad8e9c4a511
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.