1344829 - add BUG_COMPONENT to security/* files

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

to ensure bugs get to the right component, we want to map all the source files in-tree to the proper bugzilla components.

I have this figured out:
$ ./mach file-info bugzilla-component security/**
Core :: Build Config
  security/generate_certdata.py
  security/generate_mapfile.py
Core :: Security: PSM
  security/apps
  security/certverifier
  security/manager
  security/moz.build
  security/nss
  security/nss.symbols
  security/patches
  security/pkix
Core :: Security: Process Sandboxing
  security/sandbox



I am confused about security/nss/* and security/patches/*, these seem to be nss imported code from (https://hg.mozilla.org/projects/nss), if we find code that is problematic here, should we file bugs in security:psm, or nss:??

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to security/*

Comment 2

[Franziskus Kiefer [:franziskus]]

> I am confused about security/nss/* and security/patches/*, these seem to be nss imported code from (https://hg.mozilla.org/projects/nss), if we find code that is problematic here, should we file bugs in security:psm, or nss:??

Yep. For NSS at least. Patches isn't really used afaik.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8844108 [details] [diff] [review]
add BUG_COMPONENT to security/*

Review of attachment 8844108 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. We should probably just remove the patches directory.

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler]]

(In reply to Joel Maher ( :jmaher) from comment #0)
> code that is problematic here, should we file bugs in security:psm, or nss:??

NSS :: Libraries would probably be best.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to security/* and remove patches/ dir

updated nss to be NSS:Libraries and removed the security/patches/ directory:

$ ./mach file-info bugzilla-component security/**
Core :: Build Config
  security/generate_certdata.py
  security/generate_mapfile.py
Core :: Security: PSM
  security/apps
  security/certverifier
  security/manager
  security/moz.build
  security/pkix
Core :: Security: Process Sandboxing
  security/sandbox
NSS :: Libraries
  security/nss
  security/nss.symbols

with those few changes, I thought it best to ask for a r? again.

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8844828 [details] [diff] [review]
add BUG_COMPONENT to security/* and remove patches/ dir

Review of attachment 8844828 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, LGTM.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aad8e9c4a511
add BUG_COMPONENT to security/* files. r=keeler

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aad8e9c4a511