1344831 - Enable flake8 rule E703: "statement ends with a semicolon"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1344718 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E703rule, "statement ends with a semicolon":

1) Remove the E703 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems

Comment 1

[Deepjyoti Mondal]

Attachment: bug1344831.patch

removed ending semicolons.

Comment 2

[Alessio Placitelli [:Dexter]]

Comment on attachment 8845512 [details] [diff] [review]
bug1344831.patch

Review of attachment 8845512 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks!

Comment 3

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e83304c6cc5da3a0c82c44734421ae98082bd9f
Bug 1344831 - Enable flake8 rule E703: "statement ends with a semicolon". r=dexter

Comment 4

[Paavini Nanda]

(In reply to Deepjyoti Mondal from comment #1)
> Created attachment 8845512 [details] [diff] [review]
> bug1344831.patch
> 
> removed ending semicolons.

How did you create this patch ?

Comment 5

[Deepjyoti Mondal]

@Paavini After making the changes, commit your changes by 'hg commit', this will open up your default edittor (may be VIM). Write a commit message of the form Bug <Bug_id> - <What the patch does> r?<reviewer_name> after that write a short description(optional) then exit your edittor after saving changes, your changes will be committed in your repo. Now apply 'hg export tip > /path/to/a/file.patch' . You patch will be created at the specified location.
Next you can upload your patch and ask a reviewer to review it (review flag). Hope this helps you :)

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e83304c6cc5