1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1344831 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E502 rule: "the backslash is redundant between brackets"

1) Remove the E502 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems

Comment 1

[Federico Padua [:fedepad]]

Done.

Tests passed.
Pushing for review.

Comment 2

[Federico Padua [:fedepad]]

Attachment: Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

This patch enables flake8 rule E502:
"the backslash is redundant between brackets" in toolkit/components/telemetry
by removing the relative E502 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E502 error was reported.
Precisely 8 errors violating E502 rule were found and solved.

Review commit: https://reviewboard.mozilla.org/r/119884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119884/

Comment 3

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846897 [details]
Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

https://reviewboard.mozilla.org/r/119884/#review121920

This looks good. Please make sure that this also passes xpcshell tests, both locally and on try servers. You can try locally by issuing the "./mach test toolkit/components/telemetry/unit" command.

For the try server part, select "Trigger a try build" from the Automation menu here on MozReview. Then pick a few platforms (linux, windows, macos) and only enable xpcshell tests.

Comment 4

[Federico Padua [:fedepad]]

Comment on attachment 8846897 [details]
Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

https://reviewboard.mozilla.org/r/119884/#review121920

I already ran the tests locally before pushing for review using "./mach test", which according to the commit it selects the right tests to run.
The tests all passed.
I re-ran using your command and it runs the same tests as with just "./mach test".
Just a minor thing, your line to trigger the tests should be:
"./mach test toolkit/components/telemetry/tests/unit" and not "./mach test toolkit/components/telemetry/unit": a missing "tests" directory.
I will trigger a try build here now.

Comment 5

[Federico Padua [:fedepad]]

Comment on attachment 8846897 [details]
Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

https://reviewboard.mozilla.org/r/119884/#review121920

I cannot trigger a try build here, the fields in Automation are greyed out for me, which means probably I don't have the rights to do it.
If you have, could you in case trigger it? Otherwise I don't know how to do it ;)

Comment 6

[Federico Padua [:fedepad]]

Comment on attachment 8846897 [details]
Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

https://reviewboard.mozilla.org/r/119884/#review121920

It looks like the try builds were successfull.
What are the next steps for this?
Thanks!

Comment 7

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 0c12b9761ea4 -d a6c7a9fcfc29: rebasing 382075:0c12b9761ea4 "Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r=Dexter" (tip)
merging toolkit/components/telemetry/.flake8
warning: conflicts while merging toolkit/components/telemetry/.flake8! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846897 [details]
Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

https://reviewboard.mozilla.org/r/119884/#review121920

Please rebase your commit.

Comment 9

[Federico Padua [:fedepad]]

Comment on attachment 8846897 [details]
Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

https://reviewboard.mozilla.org/r/119884/#review121920

Ok! I see from the documentation (http://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/firefoxworkflow.html?highlight=rebase) I should do:

hg up my-bookmark
hg pull
hg rebase -d inbound
hg push -r . inbound


Is that correct? Do I also need to do 

hg histedit

in between (right before pushing) as mentioned in the doc?
And is it correct to push to inbound or should be pushed to review?

Thanks!

Comment 10

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846897 [details]
Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

https://reviewboard.mozilla.org/r/119884/#review121920

You should rebase on [autoland](http://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/firefoxworkflow.html?highlight=rebase#autolanding), and then push to review again. There's no need to push/rebase to inbound, as we're planning to land this patch using MozReview anyway, not manually :)

Comment 11

[Federico Padua [:fedepad]]

Comment on attachment 8846897 [details]
Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119884/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0a87984f613
Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter r=Dexter

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e0a87984f613