1344836 - Enable flake8 rule E713: "test for membership should be 'not in'"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1344834 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E713, "test for membership should be 'not in'":

1) Remove the E713 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems

Comment 1

[Federico Padua [:fedepad]]

Attachment: Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'".

This patch enables flake8 rule E713:
"test for membership should be 'not in'" in toolkit/components/telemetry
by removing the relative E713 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E713 error was reported.
Precisely 6 errors violating E713 rule were found and solved.

Review commit: https://reviewboard.mozilla.org/r/119918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119918/

Comment 2

[Federico Padua [:fedepad]]

Done, tests pass (./mach test).
Submitted for review.

Comment 3

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846912 [details]
Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'".

https://reviewboard.mozilla.org/r/119918/#review122654

This looks good, thanks. Let me push that to try to make sure nothing is broken on the telemetry side due to that change.

Comment 4

[Federico Padua [:fedepad]]

Comment on attachment 8846912 [details]
Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'".

https://reviewboard.mozilla.org/r/119918/#review122654

Perfect, thanks!

Comment 5

[Federico Padua [:fedepad]]

Comment on attachment 8846912 [details]
Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'".

https://reviewboard.mozilla.org/r/119918/#review122654

It needs to be rebased. 
I will do it after we deal with https://reviewboard.mozilla.org/r/119900/

Comment 6

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846912 [details]
Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'".

https://reviewboard.mozilla.org/r/119918/#review122654

Now that the other bug landed, would you please rebase this?

Comment 7

[Federico Padua [:fedepad]]

Comment on attachment 8846912 [details]
Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'".

https://reviewboard.mozilla.org/r/119918/#review122654

Yes, I'm going to do it now...

Comment 8

[Federico Padua [:fedepad]]

Comment on attachment 8846912 [details]
Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119918/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5f899fa1771
Enable flake8 rule E713: "test for membership should be 'not in'". r=Dexter

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d5f899fa1771