Enable flake8 rule E231: "missing whitespace after ','"

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Telemetry
P3
normal
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: Dexter, Assigned: Paavini Nanda, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla55
good-first-bug
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client][lang=python])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 months ago
+++ This bug was initially created as a clone of Bug #1344836 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E231, "missing whitespace after ','":

1) Remove the E231rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems
(Reporter)

Updated

4 months ago
No longer depends on: 1344836
(Reporter)

Updated

4 months ago
Blocks: 1344841
(Reporter)

Updated

4 months ago
No longer blocks: 1344841
(Reporter)

Updated

4 months ago
Keywords: good-first-bug
(Assignee)

Comment 1

4 months ago
Created attachment 8846471 [details] [diff] [review]
Added missing whitespaces
(Assignee)

Comment 2

4 months ago
Please assign this to me. Solved the bug.
(Assignee)

Comment 3

4 months ago
Created attachment 8846473 [details] [diff] [review]
added whitespaces
Attachment #8846471 - Attachment is obsolete: true
Attachment #8846473 - Flags: review+
(Assignee)

Comment 4

4 months ago
Sorry i did review+ by mistake.
Flags: needinfo?(alessio.placitelli)
(Reporter)

Updated

4 months ago
Assignee: nobody → paavininanda
(Reporter)

Updated

4 months ago
Flags: needinfo?(alessio.placitelli)
Attachment #8846473 - Flags: review+ → review?(alessio.placitelli)
(Assignee)

Comment 5

4 months ago
Created attachment 8846767 [details] [diff] [review]
bug1344840.patch
Attachment #8846473 - Attachment is obsolete: true
Attachment #8846473 - Flags: review?(alessio.placitelli)
(Assignee)

Updated

4 months ago
Attachment #8846767 - Flags: review?(gfritzsche)
Attachment #8846767 - Flags: review?(gfritzsche) → review?(alessio.placitelli)
(Reporter)

Comment 6

4 months ago
Comment on attachment 8846767 [details] [diff] [review]
bug1344840.patch

Review of attachment 8846767 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks!
Attachment #8846767 - Flags: review?(alessio.placitelli) → review+
(Assignee)

Updated

4 months ago
Attachment #8846767 - Flags: checkin?
(Reporter)

Updated

4 months ago
Attachment #8846767 - Flags: checkin?
(Reporter)

Comment 7

4 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/83eb15651f24e14962ef4033a8544092bc3fa580
Bug 1344840 - Enable flake8 rule E231: "missing whitespace after ','". r=dexter

Comment 8

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/83eb15651f24
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox54: affected → ---
You need to log in before you can comment on or make changes to this bug.