Closed
Bug 1344840
Opened 8 years ago
Closed 8 years ago
Enable flake8 rule E231: "missing whitespace after ','"
Categories
(Toolkit :: Telemetry, enhancement, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: Dexter, Assigned: paavininanda, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [measurement:client][lang=python])
Attachments
(1 file, 2 obsolete files)
|
11.02 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1344836 +++
In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.
This bug is about enabling the E231, "missing whitespace after ','":
1) Remove the E231rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry
2) Run "./mach lint -l flake8 toolkit/components/telemetry".
3) Fix the reported problems
|
Reporter | |
Updated•8 years ago
|
Keywords: good-first-bug
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
Please assign this to me. Solved the bug.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8846471 -
Attachment is obsolete: true
Attachment #8846473 -
Flags: review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Sorry i did review+ by mistake.
Flags: needinfo?(alessio.placitelli)
|
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → paavininanda
|
|
Reporter | |
Updated•8 years ago
|
Flags: needinfo?(alessio.placitelli)
Attachment #8846473 -
Flags: review+ → review?(alessio.placitelli)
|
|
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8846473 -
Attachment is obsolete: true
Attachment #8846473 -
Flags: review?(alessio.placitelli)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8846767 -
Flags: review?(gfritzsche)
|
||
Updated•8 years ago
|
Attachment #8846767 -
Flags: review?(gfritzsche) → review?(alessio.placitelli)
|
|
Reporter | |
Comment 6•8 years ago
|
||
Comment on attachment 8846767 [details] [diff] [review]
bug1344840.patch
Review of attachment 8846767 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good, thanks!
Attachment #8846767 -
Flags: review?(alessio.placitelli) → review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8846767 -
Flags: checkin?
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8846767 -
Flags: checkin?
|
|
Reporter | |
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/83eb15651f24e14962ef4033a8544092bc3fa580
Bug 1344840 - Enable flake8 rule E231: "missing whitespace after ','". r=dexter
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•8 years ago
|
status-firefox54:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•