1344837 - add BUG_COMPONENT to mozglue/* files

Status: RESOLVED FIXED

(Core :: mozglue, enhancement)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to mozglue/*

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8844115 [details] [diff] [review]
add BUG_COMPONENT to mozglue/*

Review of attachment 8844115 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/android/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +with Files("**"):
> +    BUG_COMPONENT = ("Firefox for Android", "General")

Better to keep in Core::mozglue.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to mozglue/*

thanks for the pointer on android/, I have updated the patch

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8844824 [details] [diff] [review]
add BUG_COMPONENT to mozglue/*

Review of attachment 8844824 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/android/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +with Files("**"):
> +    BUG_COMPONENT = ("Core", "mozglue")

You don't need to change anything in this file, considering it will inherit from mozglue/moz.build.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d83ab67aa3
add BUG_COMPONENT to mozglue/* files. r=glandium

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d2d83ab67aa3