Closed
Bug 1344837
Opened 7 years ago
Closed 7 years ago
add BUG_COMPONENT to mozglue/* files
Categories
(Core :: mozglue, enhancement)
Core
mozglue
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.39 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8844115 [details] [diff] [review] add BUG_COMPONENT to mozglue/* Review of attachment 8844115 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozglue/android/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Firefox for Android", "General") Better to keep in Core::mozglue.
Attachment #8844115 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Comment 3•7 years ago
|
||
thanks for the pointer on android/, I have updated the patch
Attachment #8844115 -
Attachment is obsolete: true
Attachment #8844824 -
Flags: review?(mh+mozilla)
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8844824 [details] [diff] [review] add BUG_COMPONENT to mozglue/* Review of attachment 8844824 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozglue/android/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "mozglue") You don't need to change anything in this file, considering it will inherit from mozglue/moz.build.
Attachment #8844824 -
Flags: review?(mh+mozilla) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d83ab67aa3 add BUG_COMPONENT to mozglue/* files. r=glandium
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d2d83ab67aa3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•