Closed Bug 1344842 Opened 5 years ago Closed 5 years ago

Enable flake8 rule E261: "at least two spaces before inline comment"

Categories

(Toolkit :: Telemetry, enhancement, P3)

enhancement
Points:
1

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: Dexter, Assigned: paavininanda, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [measurement:client][lang=python])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1344841 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E261, "at least two spaces before inline comment":

1) Remove the E261 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems
No longer depends on: 1344841
Blocks: 1344844
No longer blocks: 1344844
Keywords: good-first-bug
please assign this to me
Please assign this to me and provide the review too.
Flags: needinfo?(alessio.placitelli)
Assignee: nobody → paavininanda
Flags: needinfo?(alessio.placitelli)
Attachment #8846483 - Flags: review?(alessio.placitelli)
Comment on attachment 8846483 [details] [diff] [review]
added whitespaces before comments.

Review of attachment 8846483 [details] [diff] [review]:
-----------------------------------------------------------------

Please change the commit message to be one line. For example:

Bug 1344842: Enable flake8 rule E261: "at least two spaces before inline comment". r?dexter
Attachment #8846483 - Flags: review?(alessio.placitelli)
Attached patch bug1344842.patchSplinter Review
Attachment #8846483 - Attachment is obsolete: true
Attachment #8846773 - Flags: review?(gfritzsche)
Attachment #8846773 - Flags: review?(gfritzsche) → review?(alessio.placitelli)
Comment on attachment 8846773 [details] [diff] [review]
bug1344842.patch

Review of attachment 8846773 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good now, thank you!
Attachment #8846773 - Flags: review?(alessio.placitelli) → review+
Attachment #8846773 - Flags: checkin?
Attachment #8846773 - Flags: checkin?
https://hg.mozilla.org/integration/mozilla-inbound/rev/267e93a16cfe0a481f48c13efcff6f9dd7939280
Bug 1344842 - Enable flake8 rule E261: "at least two spaces before inline comment". r=dexter
https://hg.mozilla.org/mozilla-central/rev/267e93a16cfe
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.