Enable flake8 rule E261: "at least two spaces before inline comment"

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Dexter, Assigned: paavininanda, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla55
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client][lang=python])

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1344841 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E261, "at least two spaces before inline comment":

1) Remove the E261 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems
No longer depends on: 1344841
No longer blocks: 1344844
Assignee

Comment 1

2 years ago
please assign this to me
Assignee

Comment 2

2 years ago
Assignee

Comment 3

2 years ago
Please assign this to me and provide the review too.
Flags: needinfo?(alessio.placitelli)
Assignee: nobody → paavininanda
Flags: needinfo?(alessio.placitelli)
Attachment #8846483 - Flags: review?(alessio.placitelli)
Comment on attachment 8846483 [details] [diff] [review]
added whitespaces before comments.

Review of attachment 8846483 [details] [diff] [review]:
-----------------------------------------------------------------

Please change the commit message to be one line. For example:

Bug 1344842: Enable flake8 rule E261: "at least two spaces before inline comment". r?dexter
Attachment #8846483 - Flags: review?(alessio.placitelli)
Assignee

Comment 5

2 years ago
Attachment #8846483 - Attachment is obsolete: true
Assignee

Updated

2 years ago
Attachment #8846773 - Flags: review?(gfritzsche)
Attachment #8846773 - Flags: review?(gfritzsche) → review?(alessio.placitelli)
Comment on attachment 8846773 [details] [diff] [review]
bug1344842.patch

Review of attachment 8846773 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good now, thank you!
Attachment #8846773 - Flags: review?(alessio.placitelli) → review+
Assignee

Updated

2 years ago
Attachment #8846773 - Flags: checkin?

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/267e93a16cfe
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.