1344842 - Enable flake8 rule E261: "at least two spaces before inline comment"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1344841 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E261, "at least two spaces before inline comment":

1) Remove the E261 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems

Comment 1

[Paavini Nanda]

please assign this to me

Comment 2

[Paavini Nanda]

Attachment: added whitespaces before comments.

Comment 3

[Paavini Nanda]

Please assign this to me and provide the review too.

Comment 4

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846483 [details] [diff] [review]
added whitespaces before comments.

Review of attachment 8846483 [details] [diff] [review]:
-----------------------------------------------------------------

Please change the commit message to be one line. For example:

Bug 1344842: Enable flake8 rule E261: "at least two spaces before inline comment". r?dexter

Comment 5

[Paavini Nanda]

Attachment: bug1344842.patch

Comment 6

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846773 [details] [diff] [review]
bug1344842.patch

Review of attachment 8846773 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good now, thank you!

Comment 7

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/267e93a16cfe0a481f48c13efcff6f9dd7939280
Bug 1344842 - Enable flake8 rule E261: "at least two spaces before inline comment". r=dexter

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/267e93a16cfe