Enable flake8 rule E222: "multiple spaces after operator"

RESOLVED FIXED in Firefox 55

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Dexter, Assigned: fedepad, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla55
good-first-bug
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client][lang=python])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1344842 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E222, "multiple spaces after operator":

1) Remove the E222 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems
(Reporter)

Updated

2 years ago
No longer depends on: 1344842
(Reporter)

Updated

2 years ago
Blocks: 1344846
(Reporter)

Updated

2 years ago
No longer blocks: 1344846
(Reporter)

Updated

2 years ago
Keywords: good-first-bug

Comment 1

2 years ago
I would like to work on this.
(Assignee)

Comment 2

2 years ago
Done. Tests pass.
Submitted for review.
Comment hidden (mozreview-request)
(Reporter)

Comment 4

2 years ago
(In reply to Deepjyoti Mondal from comment #1)
> I would like to work on this.

Deepjyoti, maybe you should look into more involving bugs, as this is a good bug for starting out developing :)
(Reporter)

Updated

2 years ago
Assignee: nobody → federico_padua

Comment 5

2 years ago
@Alessio okay :)

Comment 6

2 years ago
I'd like to try and fix this bug.
(Reporter)

Comment 7

2 years ago
(In reply to sasa cocic from comment #6)
> I'd like to try and fix this bug.

Sasa, I'm afraid this bug is already being worked on (it's in review). You can find another bug to work on here: http://www.joshmatthews.net/bugsahoy/
(Reporter)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

This looks good, thanks. I'm fairly confident that you'll need to rebase this :-) There's a lot of linting relating bugs landing at the same time.. and a lot of conflicts over the flake8 file ;)
Attachment #8846906 - Flags: review?(alessio.placitelli) → review+
(Assignee)

Comment 9

2 years ago
mozreview-review-reply
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

True, I'm pretty sure I will need to rebase! 
Yes, I've seen all the linting related bugs ;)
I can rebase and repush now...
Comment hidden (mozreview-request)
(Assignee)

Comment 11

2 years ago
mozreview-review-reply
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Rebased to latest central and pushed here. 
I ran also tests locally and they ran fine.

Comment 12

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f8f5a34b81f1 -d b267bced06cc: rebasing 382397:f8f5a34b81f1 "Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator". r=Dexter" (tip)
merging toolkit/components/telemetry/.flake8
warning: conflicts while merging toolkit/components/telemetry/.flake8! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
(Reporter)

Comment 13

2 years ago
mozreview-review-reply
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Ouch, it looks like you should rebase this again :)
(Assignee)

Comment 14

2 years ago
mozreview-review-reply
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Yes, I will do it a bit later...
I bet it's because of this: https://hg.mozilla.org/integration/autoland/rev/b23a39f0707e  ;)
Comment hidden (mozreview-request)
(Assignee)

Comment 16

2 years ago
mozreview-review-reply
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Done! I rebased...should be fine now...I hope ;)

Comment 17

2 years ago
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c8098c86e44c
Enable flake8 rule E222: "multiple spaces after operator". r=Dexter

Comment 18

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c8098c86e44c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox54: affected → ---
You need to log in before you can comment on or make changes to this bug.