Closed Bug 1344844 Opened 5 years ago Closed 5 years ago

Enable flake8 rule E222: "multiple spaces after operator"

Categories

(Toolkit :: Telemetry, enhancement, P3)

enhancement
Points:
1

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: Dexter, Assigned: fedepad, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [measurement:client][lang=python])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1344842 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E222, "multiple spaces after operator":

1) Remove the E222 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems
No longer depends on: 1344842
Blocks: 1344846
No longer blocks: 1344846
Keywords: good-first-bug
I would like to work on this.
Done. Tests pass.
Submitted for review.
(In reply to Deepjyoti Mondal from comment #1)
> I would like to work on this.

Deepjyoti, maybe you should look into more involving bugs, as this is a good bug for starting out developing :)
Assignee: nobody → federico_padua
@Alessio okay :)
I'd like to try and fix this bug.
(In reply to sasa cocic from comment #6)
> I'd like to try and fix this bug.

Sasa, I'm afraid this bug is already being worked on (it's in review). You can find another bug to work on here: http://www.joshmatthews.net/bugsahoy/
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

This looks good, thanks. I'm fairly confident that you'll need to rebase this :-) There's a lot of linting relating bugs landing at the same time.. and a lot of conflicts over the flake8 file ;)
Attachment #8846906 - Flags: review?(alessio.placitelli) → review+
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

True, I'm pretty sure I will need to rebase! 
Yes, I've seen all the linting related bugs ;)
I can rebase and repush now...
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Rebased to latest central and pushed here. 
I ran also tests locally and they ran fine.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f8f5a34b81f1 -d b267bced06cc: rebasing 382397:f8f5a34b81f1 "Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator". r=Dexter" (tip)
merging toolkit/components/telemetry/.flake8
warning: conflicts while merging toolkit/components/telemetry/.flake8! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Ouch, it looks like you should rebase this again :)
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Yes, I will do it a bit later...
I bet it's because of this: https://hg.mozilla.org/integration/autoland/rev/b23a39f0707e  ;)
Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Done! I rebased...should be fine now...I hope ;)
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c8098c86e44c
Enable flake8 rule E222: "multiple spaces after operator". r=Dexter
https://hg.mozilla.org/mozilla-central/rev/c8098c86e44c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.