1344844 - Enable flake8 rule E222: "multiple spaces after operator"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1344842 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E222, "multiple spaces after operator":

1) Remove the E222 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems

Comment 1

[Deepjyoti Mondal]

I would like to work on this.

Comment 2

[Federico Padua [:fedepad]]

Done. Tests pass.
Submitted for review.

Comment 3

[Federico Padua [:fedepad]]

Attachment: Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

This patch enables flake8 rule E222:
"multiple spaces after operator" in toolkit/components/telemetry
by removing the relative E222 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E222 error was reported.
Precisely 1 error violating E222 rule was found and solved.

Review commit: https://reviewboard.mozilla.org/r/119900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119900/

Comment 4

[Alessio Placitelli [:Dexter]]

(In reply to Deepjyoti Mondal from comment #1)
> I would like to work on this.

Deepjyoti, maybe you should look into more involving bugs, as this is a good bug for starting out developing :)

Comment 5

[Deepjyoti Mondal]

@Alessio okay :)

Comment 6

[sasa cocic]

I'd like to try and fix this bug.

Comment 7

[Alessio Placitelli [:Dexter]]

(In reply to sasa cocic from comment #6)
> I'd like to try and fix this bug.

Sasa, I'm afraid this bug is already being worked on (it's in review). You can find another bug to work on here: http://www.joshmatthews.net/bugsahoy/

Comment 8

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

This looks good, thanks. I'm fairly confident that you'll need to rebase this :-) There's a lot of linting relating bugs landing at the same time.. and a lot of conflicts over the flake8 file ;)

Comment 9

[Federico Padua [:fedepad]]

Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

True, I'm pretty sure I will need to rebase! 
Yes, I've seen all the linting related bugs ;)
I can rebase and repush now...

Comment 10

[Federico Padua [:fedepad]]

Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119900/diff/1-2/

Comment 11

[Federico Padua [:fedepad]]

Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Rebased to latest central and pushed here. 
I ran also tests locally and they ran fine.

Comment 12

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f8f5a34b81f1 -d b267bced06cc: rebasing 382397:f8f5a34b81f1 "Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator". r=Dexter" (tip)
merging toolkit/components/telemetry/.flake8
warning: conflicts while merging toolkit/components/telemetry/.flake8! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 13

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Ouch, it looks like you should rebase this again :)

Comment 14

[Federico Padua [:fedepad]]

Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Yes, I will do it a bit later...
I bet it's because of this: https://hg.mozilla.org/integration/autoland/rev/b23a39f0707e  ;)

Comment 15

[Federico Padua [:fedepad]]

Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119900/diff/2-3/

Comment 16

[Federico Padua [:fedepad]]

Comment on attachment 8846906 [details]
Bug 1344844 - Enable flake8 rule E222: "multiple spaces after operator".

https://reviewboard.mozilla.org/r/119900/#review122652

Done! I rebased...should be fine now...I hope ;)

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8098c86e44c
Enable flake8 rule E222: "multiple spaces after operator". r=Dexter

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c8098c86e44c