Enable flake8 rule E202: "whitespace before '}'"

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Telemetry
P3
normal
RESOLVED FIXED
4 months ago
29 days ago

People

(Reporter: Dexter, Assigned: Pauline, Mentored)

Tracking

Trunk
mozilla55
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client][lang=python])

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
+++ This bug was initially created as a clone of Bug #1344849 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E202, "whitespace before '}'":

1) Remove the E202 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems
(Reporter)

Updated

4 months ago
No longer depends on: 1344849
(Reporter)

Updated

4 months ago
Blocks: 1344852
(Reporter)

Updated

4 months ago
No longer blocks: 1344852
(Reporter)

Updated

4 months ago
Keywords: good-first-bug
I'd like to work on this issue. Could you please assign it to me? Thanks.
(Reporter)

Comment 2

3 months ago
(In reply to Pooja Gadige (:pgadige) from comment #1)
> I'd like to work on this issue. Could you please assign it to me? Thanks.

Let's land the other bug you have assigned before taking on new work :)

Comment 3

3 months ago
hwllo, i'd like to work on this issue
(Reporter)

Updated

3 months ago
Assignee: nobody → shreab373
(Reporter)

Comment 4

3 months ago
Unassigning due to inactivity.
Assignee: shreab373 → nobody
(Assignee)

Comment 5

3 months ago
Created attachment 8853052 [details] [diff] [review]
Removed the E202 rule from the .flake8 file in source/toolkit/components/telemetry

This bug may have been partially solved already because running "./mach lint -l flake8 toolkit/components/telemetry" after removing the rule E202 from the .flake8 file did not report any problem. I am therefore submitting a patch only for the update of the .flake8 file
(Reporter)

Comment 6

3 months ago
Comment on attachment 8853052 [details] [diff] [review]
Removed the E202 rule from the .flake8 file in source/toolkit/components/telemetry

Review of attachment 8853052 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks!
Attachment #8853052 - Flags: review+
(Reporter)

Updated

3 months ago
Assignee: nobody → pauline.lallinec
Status: NEW → ASSIGNED
(Reporter)

Updated

3 months ago
Keywords: good-first-bug → checkin-needed

Comment 7

3 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f0467f930f
Remove the E202 rule from the .flake8 file in source/toolkit/components/telemetry. r=Dexter
Keywords: checkin-needed

Comment 8

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e0f0467f930f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox54: affected → ---
You need to log in before you can comment on or make changes to this bug.