1344849 - Enable flake8 rule E201: "whitespace after '{'"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1344846 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the E201, "whitespace after '{'":

1) Remove the E201 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems

Comment 1

[Deepjyoti Mondal]

Attachment: bug1344849.patch

Removed white space before '{'

Comment 2

[Alessio Placitelli [:Dexter]]

Comment on attachment 8846424 [details] [diff] [review]
bug1344849.patch

Review of attachment 8846424 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/gen-histogram-bucket-ranges.py
@@ +46,4 @@
>          except histogram_tools.DefinitionException:
>              continue
>  
> +        all_histograms.update({name: parameters });

Let's also trim the whitespace after |parameters|, before }

::: toolkit/components/telemetry/histogram_tools.py
@@ +135,1 @@
>                       'opt-out': 'DATASET_RELEASE_CHANNEL_OPTOUT' }

Let's align 'opt-out' to 'opt-in' on the previous line. Let's also remove the whitespace after 'DATASET_RELEASE_CHANNEL_OPTOUT', before }

Comment 3

[Deepjyoti Mondal]

Attachment: bug1344849.patch

Made the necessary changes.

Comment 4

[Alessio Placitelli [:Dexter]]

Comment on attachment 8847586 [details] [diff] [review]
bug1344849.patch

Review of attachment 8847586 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks!

Comment 5

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b23a39f0707e969ef2de914f72462e335b26d863
Bug 1344849 - Enabled flake8 rule E201: "whitespace after '{'". r=Dexter

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b23a39f0707e