1344860 - add BUG_COMPONENT to many root level files files

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to many root level files

possibly there are some things done incorrectly, please feel free to suggest other things or ask me to investigate more as needed.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8844121 [details] [diff] [review]
add BUG_COMPONENT to many root level files

Review of attachment 8844121 [details] [diff] [review]:
-----------------------------------------------------------------

A few suggestions for different components but otherwise this is fine.

::: moz.build
@@ +3,5 @@
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +# These 3 files really don't belong in Build Config, not sure where

I think "mozilla.org :: Licensing" would be appropriate:
https://bugzilla.mozilla.org/describecomponents.cgi?product=mozilla.org&component=Licensing#Licensing

@@ +11,5 @@
> +with Files('LICENSE'):
> +    BUG_COMPONENT = ('Core', 'Build Config')
> +
> +with Files('LEGAL'):
> +    BUG_COMPONENT = ('Core', 'Build Config')

Seems like it'd be nice if `Files` accepted a list of patterns so you didn't have to repeat yourself so much here to tag individual files.

I don't have time to file this right at the moment but that code lives here:
https://dxr.mozilla.org/mozilla-central/rev/58753259bfeb3b818eac7870871b0aae1f8de64a/python/mozbuild/mozbuild/frontend/context.py#634

@@ +30,5 @@
> +with Files('*configure*'):
> +    BUG_COMPONENT = ('Core', 'Build Config')
> +
> +with Files('mach'):
> +    BUG_COMPONENT = ('Core', 'Build Config')

Core :: mach

@@ +42,5 @@
> +with Files('*gradle*'):
> +    BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
> +
> +with Files('README.txt'):
> +    BUG_COMPONENT = ('Core', 'Build Config')

I'd stick this in Core :: General or something, I dunno.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9e58225837b
add BUG_COMPONENT to many root level files files. r=ted

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e9e58225837b