add BUG_COMPONENT to many root level files files

RESOLVED FIXED in Firefox 55

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

No description provided.
possibly there are some things done incorrectly, please feel free to suggest other things or ask me to investigate more as needed.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8844121 - Flags: review?(ted)
Comment on attachment 8844121 [details] [diff] [review]
add BUG_COMPONENT to many root level files

Review of attachment 8844121 [details] [diff] [review]:
-----------------------------------------------------------------

A few suggestions for different components but otherwise this is fine.

::: moz.build
@@ +3,5 @@
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +# These 3 files really don't belong in Build Config, not sure where

I think "mozilla.org :: Licensing" would be appropriate:
https://bugzilla.mozilla.org/describecomponents.cgi?product=mozilla.org&component=Licensing#Licensing

@@ +11,5 @@
> +with Files('LICENSE'):
> +    BUG_COMPONENT = ('Core', 'Build Config')
> +
> +with Files('LEGAL'):
> +    BUG_COMPONENT = ('Core', 'Build Config')

Seems like it'd be nice if `Files` accepted a list of patterns so you didn't have to repeat yourself so much here to tag individual files.

I don't have time to file this right at the moment but that code lives here:
https://dxr.mozilla.org/mozilla-central/rev/58753259bfeb3b818eac7870871b0aae1f8de64a/python/mozbuild/mozbuild/frontend/context.py#634

@@ +30,5 @@
> +with Files('*configure*'):
> +    BUG_COMPONENT = ('Core', 'Build Config')
> +
> +with Files('mach'):
> +    BUG_COMPONENT = ('Core', 'Build Config')

Core :: mach

@@ +42,5 @@
> +with Files('*gradle*'):
> +    BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
> +
> +with Files('README.txt'):
> +    BUG_COMPONENT = ('Core', 'Build Config')

I'd stick this in Core :: General or something, I dunno.
Attachment #8844121 - Flags: review?(ted) → review+

Comment 3

2 years ago
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9e58225837b
add BUG_COMPONENT to many root level files files. r=ted

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e9e58225837b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.