1344902 - Shutdown error: 'Method not implemented' when calling method: [imIAccount::disconnect]

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[aleth [:aleth]]

On shutdown with a connected IRC account:

JavaScript error: file:Daily.app/Contents/Resources/components/imIncomingServer.js, line 228: uncaught exception: 2147500033
JavaScript error: file:Daily.app/Contents/Resources/components/imIncomingServer.js, line 228: NS_ERROR_NOT_IMPLEMENTED: Method not implemented'Method not implemented' when calling method: [imIAccount::disconnect]

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: bug1344902-v1.patch

Usually when shutdown is called, the imAccounts have already been disconnected and replaced by UnknownAccounts. In that case, we don't want to try to disconnect them.

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: bug1344902-v1.1.patch

Oops, that was not the patch it was meant to be.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8957018 [details] [diff] [review]
bug1344902-v1.1.patch

Review of attachment 8957018 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/im/imIncomingServer.js
@@ +219,5 @@
>    closeCachedConnections: function() { },
>  
>    // Shutdown the server instance so at least disconnect from the server.
>    shutdown: function() {
> +    // Ensure this is not an UnknownAccount and still connected.

This can't be an UnknownAccount. As discussed on IRC, what you are seeing is https://dxr.mozilla.org/comm-central/source/chat/components/src/imAccounts.js#637

So I think you want if (this.imAccount.prplAccount)

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: bug1344902-v2.patch

Change to checking if an imAccount has been un-inited, as discussed. Fixes the problem for me and disconnecting seems to still work generally.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8957209 [details] [diff] [review]
bug1344902-v2.patch

Review of attachment 8957209 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1261ad9b3329
Don't try to disconnect dummy accounts. r=florian