1344947 - Update webrender to e30fb2914928c0e596d8632ed234647c0fd1492e

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1343019 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 3dd773f5a2b69ad39418e032f38fd70e5f26a3c8

https://treeherder.mozilla.org/#/jobs?repo=try&revision=426c5d63886fd8805c3b4c1b40869f66dab4234e

Seems ok, modulo some infra-looking problems and known R1 failures. I should note that a previous push @ 3662aebbd9c8be8acd095f8bfc38f1bb357d4683 [1] had a high R4 failure rate. I left a comment at [2] and mrobinson made a PR to fix it [3], which hasn't yet landed.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=25fefb3727904b9899431a38c5a9c77ee5abb1d0
[2] https://github.com/servo/webrender/pull/959#issuecomment-284571193
[3] https://github.com/servo/webrender/pull/967

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 3d5abca3447b8642c33b10a66656f3a4714b1803

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20d4a5a67c0b5af9d902490acdf4ee7c24ef4319

Looking green. (This includes mrobinson's PR that I mentioned in the previous comment).

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ ad3421764cec0b31dbc2eefecf0230a83efbdb84

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2d7770a60c8a621246a6f59a732beca639fc2ac

Bustage.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ ad3421764cec0b31dbc2eefecf0230a83efbdb84, with fixup:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9ee04b0b839d5ff1154bb71ea9e8a3c244342dd

Looking good.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 9dcc5590421029be3b1bd8a790c684390e084ed3

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44a682c994f3301ffc71d2301c1206c500a0414f

Much orange, but a lot of it is UNEXPECTED-PASS. There's a few UNEXPECTED-FAIL, but at first glance we are passing more than failing, so that's good.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ e30fb2914928c0e596d8632ed234647c0fd1492e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4af5ad241a2a8b8af57436f8eebe78e5a6d1230

Looking green. I'd like to land this update so we lock in the reftest fixes. I'll put up patches.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1344947 - Update webrender to e30fb2914928c0e596d8632ed234647c0fd1492e.

Review commit: https://reviewboard.mozilla.org/r/119668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119668/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1344947 - Update Cargo.toml/Cargo.lock files.

Review commit: https://reviewboard.mozilla.org/r/119670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119670/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1344947 - Update calls to push_scroll_layer with API change.

Review commit: https://reviewboard.mozilla.org/r/119672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119672/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1344947 - Update reftest.list files with new webrender results.

Review commit: https://reviewboard.mozilla.org/r/119674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119674/

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8846645 [details]
Bug 1344947 - Update reftest.list files with new webrender results.

https://reviewboard.mozilla.org/r/119674/#review121556

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8846644 [details]
Bug 1344947 - Update calls to push_scroll_layer with API change.

https://reviewboard.mozilla.org/r/119672/#review121560

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8846643 [details]
Bug 1344947 - Update Cargo.toml/Cargo.lock files.

https://reviewboard.mozilla.org/r/119670/#review121564

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8846642 [details]
Bug 1344947 - Update webrender to e30fb2914928c0e596d8632ed234647c0fd1492e.

https://reviewboard.mozilla.org/r/119668/#review121572

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/ece6a8407078
Update webrender to e30fb2914928c0e596d8632ed234647c0fd1492e. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/26fb79e4ecca
Update reftest.list files with new webrender results. r=jrmuizel

Comment 16

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/ece6a8407078
https://hg.mozilla.org/mozilla-central/rev/26fb79e4ecca