1346915 - Caret Display items are being painted in the wrong position

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mason Chang [Inactive] [:mchang]]

Seems like something has changed. STR:

1) Go to about:preferences
2) Move cursor over "Home Page"
3) See caret icon blinking above instead of in the proper place

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Maybe another rebasing failure in bug 1345712?

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

I'm noticing the same thing for border layers.

I can see it on my about:newtab page, borders and carets are both shifted upward. It looks like they're missing an offset for chrome of some sort.

Comment 3

[Mason Chang [Inactive] [:mchang]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #1)
> Maybe another rebasing failure in bug 1345712?

I tried on a build with those patches landed, but still have the same bug.

Comment 4

[Mason Chang [Inactive] [:mchang]]

Bisection log:

Good - f6f7b64e6f3c2b914ef978a980a32935e4e63cc5
Bad - 516a3654f48007f3b0b6b4e0659f777333786b61

Bisecting: 327 revisions left to test after this (roughly 8 steps) - Good
[48e9a43dc47aab0627ea44fcb5adfa6af37eaff0] Bug 1331173 - Increase header segment capacity for TaskTracer. r=billm

Bisecting: 165 revisions left to test after this (roughly 7 steps) - Good
[70def79ce36c2a0df7d63ef6d48d0744a261bfc7] merge autoland to mozilla-central a=merge

Bisecting: 82 revisions left to test after this (roughly 6 steps) - Good
[3b8399a3a7d764af83b3e8c8961b6e5cd5c59820] Bug 1344590: Follow-up: Fix changes that got lost in rebase.

Bisecting: 41 revisions left to test after this (roughly 5 steps) - good
[b8ac5ccfaca62fb0ce83137fcdfab2604648392d] Backed out changeset a035c2b6ae72 (bug 1325940)

Bisecting: 22 revisions left to test after this (roughly 5 steps) - good
[602d7e6e424347644d2358ad27baa2d62efd7d85] Bug 1345975 - Sort WebRender binding definitions r=kats

Bisecting: 11 revisions left to test after this (roughly 4 steps) - good
[8b0fa844a83a778a39004123df894f7ba980b7e2] Bug 1346110 - Use BorderRenderer to generate wr commands for nsDisplayButtonBorder. r=mchang

Bisecting: 5 revisions left to test after this (roughly 3 steps) good
[90e35e2b18b011b88547d08ae6de26919885ac0a] Bug 1345712 - Fix rebasing failure part 2 r=jrmuizel

Bisecting: 3 revisions left to test after this (roughly 2 steps) - good
[c1edc7067d39d8c854b7c1205785c374c2d979bc] merge mozilla-inbound to mozilla-central a=merge

Bisecting: 1 revision left to test after this (roughly 1 step) - bad
[b1573d9a13d98b4a33ff3672f32ed53d16871a2d] Bug 1344947 - Update reftest.list files with new webrender results. r=jrmuizel

Bad
[ca0d33d72c5610612985f413d19fbffcdd783963] Bug 1344947 - Update webrender to e30fb2914928c0e596d8632ed234647c0fd1492e. r=jrmuizel

commit ca0d33d72c5610612985f413d19fbffcdd783963
Author: Kartikaya Gupta <[e-mail]>
Date:   Mon Mar 13 13:03:06 2017 -0400

    Bug 1344947 - Update webrender to e30fb2914928c0e596d8632ed234647c0fd1492e. r=jrmuizel
    
    This also updates calls to push_scroll_layer in webrender_bindings to go with
    a change in the API.

Comment 5

[Ethan Lin[:ethlin]]

Attachment: fix scroll layer id

The patch can fix this problem. It looks like we should reset scroll layer id when pushing the built display list.

Comment 6

[Ethan Lin[:ethlin]]

I just send a pr: https://github.com/servo/webrender/pull/981.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

The PR seems to be for a different issue?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Oh, it's this one: https://github.com/servo/webrender/pull/982. Thanks for bisecting and fixing this! I'll do another WR update to pull in the fix.

Comment 9

[Ethan Lin[:ethlin]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #8)
> Oh, it's this one: https://github.com/servo/webrender/pull/982. Thanks for
> bisecting and fixing this! I'll do another WR update to pull in the fix.

Right..I pasted a wrong one. Sorry for that.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/142aa7bf0a84
Update webrender to 7da345684dc29ca60f29cb79acc8d99c474ec477. r=me

Comment 11

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/142aa7bf0a84